Skip to content

Fix CI mypy command on free-threaded Python #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025
Merged

Fix CI mypy command on free-threaded Python #2040

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8905e9e
Fix CI `mypy` command on free-threaded Python
EliahKagan Jun 7, 2025
b45ae86
Add an explanatory comment for omitting "t"
EliahKagan Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix CI mypy command on free-threaded Python 
When the version is represented as `3.13t`, the `--python-version`
option needs an operand of `3.13`, not `3.13t`.

(This, and the fix here, will automatically apply to later threaded
Pythons, such as 3.14t, too.)
  • Loading branch information
@EliahKagan
EliahKagan committed Jun 7, 2025
commit 8905e9e8f0244414fbff90c19b144d02b74af3b3
3 changes: 2 additions & 1 deletion .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,11 @@ jobs:

- name: Check types with mypy
run: |
mypy --python-version=${{ matrix.python-version }}
mypy --python-version="${PYTHON_VERSION%t}"
env:
MYPY_FORCE_COLOR: "1"
TERM: "xterm-256color" # For color: https://github.com/python/mypy/issues/13817
PYTHON_VERSION: ${{ matrix.python-version }}
# With new versions of mypy new issues might arise. This is a problem if there is
# nobody able to fix them, so we have to ignore errors until that changes.
continue-on-error: true
Expand Down
Loading