Skip to content

correctly handle uname-cmd that doesn't point to an executable file #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 28, 2025
Merged

correctly handle uname-cmd that doesn't point to an executable file #2026

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ec00872
add tests for is_cygwin_git
gcmarx May 21, 2025
de5e57c
check for the existence/execute bit on the uname command before tryin…
gcmarx May 21, 2025
428be1a
adding self to authors
gcmarx May 21, 2025
58ff723
Revert "check for the existence/execute bit on the uname command befo…
gcmarx May 22, 2025
7187984
use pathlib.Path instead of os.path.isfile
gcmarx May 22, 2025
3f5a942
don't keep checking if sys.platform isn't 'cygwin'
gcmarx May 22, 2025
226f4ff
check that uname_cmd points to a file; if uname_cmd were a directory,…
gcmarx May 22, 2025
22d6284
don't use match-case, since it's a 3.10 feature
gcmarx May 22, 2025
b1289ee
it's is_file(), not isfile()
gcmarx May 22, 2025
cffa264
turns out f-strings before 3.8 don't support {variable=} notation, ta…
gcmarx May 22, 2025
36a893b
add self to AUTHORS, add Emacs tempfiles to .gitignore
gcmarx May 23, 2025
c441316
use `strings` instead of `uname` to detect cygwin
gcmarx May 27, 2025
0df0818
debug printing
gcmarx May 27, 2025
58f7710
Revert "debug printing"
gcmarx May 28, 2025
1731c1e
Revert "use `strings` instead of `uname` to detect cygwin"
gcmarx May 28, 2025
f3ab5d3
incorporate review feedback from @EliahKagan
gcmarx May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't keep checking if sys.platform isn't 'cygwin'
  • Loading branch information
@gcmarx
gcmarx committed May 22, 2025
commit 3f5a942be8293bb8c663631756885f877afc22e7
2 changes: 1 addition & 1 deletion git/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def is_cygwin_git(git_executable: PathLike) -> bool: ...


def is_cygwin_git(git_executable: Union[None, PathLike]) -> bool:
if sys.platform == "win32": # TODO: See if we can use `sys.platform != "cygwin"`.
if sys.platform != "cygwin":
return False
elif git_executable is None:
return False
Expand Down