Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump git/ext/gitdb from 3d3e957 to a8c894f #1970

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 14, 2024

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps git/ext/gitdb from 3d3e957 to a8c894f.

Commits
  • a8c894f Merge pull request #114 from edgarrmondragon/cp313
  • b38cbc4 Use older ubuntu to get Python 3.7
  • 5bc9504 Add support for Python 3.13
  • 88da5ef Merge pull request #113 from blablatdinov/use-contextlib-suppress
  • d50b2e3 Use contextlib.suppress instead of except: pass
  • b653923 Merge pull request #109 from Clavss/fix-issue-101
  • 24ecf58 fix #101
  • ec58b7e Merge pull request #104 from EliahKagan/cadence
  • 3753f72 Merge pull request #103 from EliahKagan/update-readme
  • 9302789 Merge pull request #102 from EliahKagan/nopathmod
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [git/ext/gitdb](https://github.com/gitpython-developers/gitdb) from `3d3e957` to `a8c894f`.
- [Release notes](https://github.com/gitpython-developers/gitdb/releases)
- [Commits](gitpython-developers/gitdb@3d3e957...a8c894f)

---
updated-dependencies:
- dependency-name: git/ext/gitdb
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Oct 14, 2024
@EliahKagan
Copy link
Contributor

It looks like e51bf80 supersedes this, so this can be closed.

(One way to close it that would avoid doing so if the belief that it is supersedes is mistaken to issue the command @dependabot rebase here. Dependabot would examine how to rebase the PR, find out that the PR is not needed, and close the PR without actually rebasing anything.)

@Byron
Copy link
Member

Byron commented Jan 2, 2025

@dependabot rebase

I guess I was too impatient, as nothing happened even after a reload or two. So closed this PR instead.

@Byron Byron closed this Jan 2, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 2, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/git/ext/gitdb-a8c894f branch January 2, 2025 13:14
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 2, 2025

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@EliahKagan
Copy link
Contributor

EliahKagan commented Jan 2, 2025

I guess I was too impatient, as nothing happened even after a reload or two. So closed this PR instead.

When given commands, Dependabot usually adds 👍 react to the comment as soon as it has identified it as a command by a user with write access on the repository that it supports and will attempt to perform. I think that beginning to carry out the command is then sometimes deferred for a short time.

But the more substantial wait with commands like @dependabot rebase is that Dependabot adds planned work to a queue and edits the PR description with an ⚠️ notice to say that it is rebasing, then eventually gets around to doing so ("Rebasing might not happen immediately"). When it does eventually do so, which in my experience is usually within a couple of minutes, it will either rebase and force push if the update has not been superseded, or not pushing anything but just close the PR and comment if the update has been superseded. (Either way, it edits the description again to remove the ⚠️ message at the top. I believe it only leaves it if the operation is interrupted and not followed by another operation of a kind that would cause it to edit the description, as happened here when the PR was closed.)

Dependabot will also eventually attempt a rebase when it detects that a PR has acquired a merge conflict due to changes on the base branch. So it would probably eventually have closed this PR even without any commands being issued, as it did in #1981. I've found that the wait for this is sometimes significantly longer, though.

@Byron
Copy link
Member

Byron commented Jan 3, 2025

Thanks for elaborating - one definitely can't say that it doesn't try everything it can to indicate that a delayed action is going to happen.
Interestingly, all seems to have failed for me as I didn't get any of it when I was waiting. Maybe my refreshes also didn't uncover the changes due to stale browser caches or something.
In future, I should be able to wait for the signs, thanks again.

@EliahKagan
Copy link
Contributor

Interestingly, all seems to have failed for me as I didn't get any of it when I was waiting.

Did the edit to the PR description (with "⚠️") not appear until after this was closed? That's unusual, but I think it could happen if the initial usually short delay is longer than typical.

Maybe my refreshes also didn't uncover the changes due to stale browser caches or something.

If so, I would guess that this would also have involved a bug on GitHub' side.

In future, I should be able to wait for the signs, thanks again.

Well, you don't have to: Closing the PR yourself keeps Dependabot from opening another PR to propose an upgrade to the same version as the PR was for, but since the reason for closing it is that this or a later version is already integrated into the main branch, that's not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Development

Successfully merging this pull request may close these issues.

2 participants