Skip to content

Revise type annotations slightly #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Revise type annotations slightly #1860

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f226fc
Remove unneeded annotation on __slots__ variable
EliahKagan Mar 5, 2024
e984bfe
Fix some underindented portions of docstrings
EliahKagan Mar 5, 2024
5d7e55b
Add return-type annotation on __init__ methods
EliahKagan Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unneeded annotation on __slots__ variable 
The correct type is inferred, and no other __slots__ variable in
the codebase has an annotation.
  • Loading branch information
@EliahKagan
EliahKagan committed Mar 5, 2024
commit 9f226fc47683038acd3304dd7d59be18984d3737
2 changes: 1 addition & 1 deletion git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ class CatFileContentStream:
rest to ensure the underlying stream continues to work.
"""

__slots__: Tuple[str, ...] = ("_stream", "_nbr", "_size")
__slots__ = ("_stream", "_nbr", "_size")

def __init__(self, size: int, stream: IO[bytes]) -> None:
self._stream = stream
Expand Down