Repository navigation
Remove unittest code from non-test code #790
Description
Activity
Good catch, I absolutely agree! Even though I am pretty sure there was a very good reason to do that at some point in time. With the current state of windows test, for which these dependencies seemingly have been introduced. Maybe @ankostis can provide more context, who did magnificent work a while ago to get windows back into shape.
Reacted by Mark Watts- added a commit that references this issue
on Nov 14, 2023 - added a commit that references this issue
on Nov 28, 2023 - added 2 commits that reference this issue
on Dec 19, 2023
I see these imports of unittest in
GitPython/git/objects/submodule/base.py
Line 6 in a8591a0
GitPython/git/util.py
Line 17 in f3265bd
I generally think that test code should not be built into the business logic. Is there a reason why using a skipIf decorator is insufficient?