Skip to content

test(view-component): add tests for view-component #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

test(view-component): add tests for view-component #841

merged 1 commit into from
Oct 26, 2018

Conversation

lucaslago
Copy link
Contributor

Question Response
Version? v1.4.1
Devices tested? n/a
Bug fix? no
New feature? no
Includes tests? yes
All Tests pass? yes
Related ticket? #518

Description

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 51.029% when pulling 5944a63 on lucaslago:add-tests-for-view-component into 6e0f6b2 on gitpoint:master.

housseindjirdeh
housseindjirdeh approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goood stuff, thank you @lucaslago

@housseindjirdeh housseindjirdeh merged commit c4609f2 into gitpoint:master Oct 26, 2018
@andrewda andrewda mentioned this pull request Dec 1, 2018
Open
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinesedfan chinesedfan chinesedfan approved these changes

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucaslago @coveralls @chinesedfan @housseindjirdeh