Test api calls #746
Merged
Test api calls #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up api tests, describe block, initial v3.call test
housseindjirdeh
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
This is great, thank you @jjlljj @etcetera8 @soytjan
Deferring to @machour for a second glance since he's been modifying our API logic - but all in all more test coverage around our API wrappers is always a good idea :)
| "contributions": [ | ||
| "code", | ||
| "test" | ||
| ] |
There was a problem hiding this comment.
Welcome to the family everyone 😊
|
Nice team work! |
|
Just a tiny little thingy that may interest you: When upgrading to last jest version, I had to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
No visual changes
Description
Added API call testing directory in
__tests___/tests/. Added API testindex.jsfile. Added tests for v3 methods: call, parameters, count, and delete.