test: add tests for NotificationIcon and RepositorySectionTitle #677
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import React from 'react'; | ||
| import { shallow, render } from 'enzyme'; | ||
| import { Badge, NotificationIconComponent } from 'components'; | ||
|
|
||
| const defaultProps = { | ||
| iconColor: 'red', | ||
| notificationsCount: 10, | ||
| }; | ||
|
|
||
| describe('<NotificationIcon />', () => { | ||
| it('should display a Badge component when notificationsCount is greater than 0', () => { | ||
| const wrapper = shallow(<NotificationIconComponent {...defaultProps} />); | ||
|
|
||
| const badges = wrapper.find(Badge); | ||
| expect(badges.length).toBe(1); | ||
| }); | ||
|
|
||
| it('should not display a Badge component when notificationsCount is 0', () => { | ||
| const wrapper = shallow( | ||
| <NotificationIconComponent {...defaultProps} notificationsCount={0} /> | ||
| ); | ||
|
|
||
| const badges = wrapper.find(Badge); | ||
| expect(badges.length).toBe(0); | ||
| }); | ||
|
|
||
| it("should display a Badge component displaying '99+' in normal text when notificationsCount is greater than 99", () => { | ||
| const wrapper = shallow( | ||
| <NotificationIconComponent {...defaultProps} notificationsCount={100} /> | ||
| ); | ||
|
|
||
| const badge = wrapper.find(Badge); | ||
| expect(badge.prop('text')).toBe('99+'); | ||
| expect(badge.prop('largeText')).toBe(false); | ||
| }); | ||
|
|
||
| it('should display a Badge component displaying notificationsCount in largeText if notificationsCount is less than or equal to 99', () => { | ||
| const wrapper = shallow( | ||
| <NotificationIconComponent {...defaultProps} notificationsCount={99} /> | ||
| ); | ||
|
|
||
| const badge = wrapper.find(Badge); | ||
|
|
||
| expect(badge.prop('text')).toBe(99); | ||
| expect(badge.prop('largeText')).toBe(true); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import React from 'react'; | ||
| import { shallow, render } from 'enzyme'; | ||
| import { RepositorySectionTitle, StateBadge } from 'components'; | ||
|
|
||
| const defaultProps = { | ||
| text: 'test title', | ||
| openCount: 10, | ||
| closedCount: 10, | ||
| loading: false, | ||
| }; | ||
|
|
||
| describe('<RepositorySectionTitle />', () => { | ||
| it('should display no StateBadge components if loading is true', () => { | ||
| const wrapper = shallow( | ||
| <RepositorySectionTitle {...defaultProps} loading={true} /> | ||
| ); | ||
| const badges = wrapper.find(StateBadge); | ||
|
|
||
| expect(badges.length).toBe(0); | ||
| }); | ||
|
|
||
| it('should display two StateBadge components if loading is false', () => { | ||
| const wrapper = shallow(<RepositorySectionTitle {...defaultProps} />); | ||
| const badges = wrapper.find(StateBadge); | ||
|
|
||
| expect(badges.length).toBe(2); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ const mapStateToProps = state => ({ | |
| notificationsCount: state.notifications.notificationsCount, | ||
| }); | ||
|
|
||
| export class NotificationIconComponent extends Component { | ||
|
There was a problem hiding this comment. Why does this need to be exported? Can you test There was a problem hiding this comment. Given NotificationIcon is this component but connected to a Redux store, the options were to either just test this inner component or to test NotificationIcon itself and mock out the store etc. I can look into the latter option. There was a problem hiding this comment. Although exporting and testing the unwrapped Component seems to be recommended by Redux: https://redux.js.org/docs/recipes/WritingTests.html#connected-components There was a problem hiding this comment. Yep, you're right! This should be exported. There was a problem hiding this comment. (not to self: we might want to make this a dumb component w/o access to redux state and do all that state management elsewhere) |
||
| props: { | ||
| iconColor: string, | ||
| notificationsCount: number, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉