test: Add test for Color Helpers (#518) #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautf
changed the title
andrewda
requested changes
Oct 24, 2017
| import { getFontColorByBackground } from 'utils'; | ||
|
|
||
| describe('Color Helpers', () => { | ||
| it('should return a black font color for the light background #1', () => { |
There was a problem hiding this comment.
Could you say something like 'should return a black font color for the light yellow background' and apply that format to the rest of these tests?
|
@andrewda done :) |
andrewda
approved these changes
Oct 24, 2017
lex111
approved these changes
Oct 24, 2017
alejandronanez
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added tests for the color helper :)