Skip to content

docs: Added app changelog #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

docs: Added app changelog #504

wants to merge 4 commits into from

Conversation

machour
Copy link
Member

@machour machour commented Oct 18, 2017

No description provided.

CHANGELOG.md Outdated
* Added "Open in browser" functionality in various screens (#424)
* Added spanish translations (#282)

## Version 1.3.0 (2017-10-04)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be no releases of bug fixes? Version 1.3.1 is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not out yet as far as I understand

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but it wasn't released yet. @housseindjirdeh mentioned on gitter that he'll be releasing it yesterday. Not sure if it was done, and what was included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this release with bug fixes has already been released (check Google Play), @housseindjirdeh meant a new release - 1.3.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but he did not update package.json, I wrote about it, but the release took place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks a lot for the clarifications!

CHANGELOG.md Outdated
* Added "Open in browser" functionality in various screens (#424)
* Added spanish translations (#282)

## Version 1.3.1 (2017-10-04)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minor, but maybe link these versions to the release on GitHub?

@andrewda
Copy link
Member

andrewda commented Oct 18, 2017

Also maybe we could eventually show this in the app near where we have the Privacy Agreement and that sort of stuff (doesn't have to go in this PR, obviously).

@housseindjirdeh
Copy link
Member

<3 Thank you @machour

@machour
Copy link
Member Author

machour commented Oct 19, 2017

@andrewda Added releases link.

Let's move this conversation to #505 where @lex111 proposed a lib to generate this file automatically

Copy link
Member

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me until we get the automates solution working.

Copy link
Member

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@housseindjirdeh I think we can merge this one with v1.4. Don't waste hard works by @machour. Haha~

@machour
Copy link
Member Author

machour commented Jan 16, 2018

Closed in favor of #696

@machour machour closed this Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants