Skip to content

feat(translation): add Esperanto translation #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 14, 2017

Conversation

kodisto
Copy link
Contributor

@kodisto kodisto commented Oct 13, 2017

For issue #439, translation of Esperanto

The esperanto flag has a star, but no emoji yet (we are working on this though!)
There's no direct for the concept of "forked", but forkis would logistically make the most since in the language. If there ever becomes a consensus on this, change it then. Otherwise I'm coining it now.
@andrewda andrewda changed the title Added Esperanto Translation feat(translation): add Esperanto translation Oct 13, 2017
@@ -35,6 +35,10 @@ export default [
name: 'Русский',
},
{
code: 'eo',
emojiCode: ':star:',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be a flag, even if it's :waving_white_flag:.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @lex111 and i have discussed how we can possibly change this, but in the meantime :waving_white_flag: should do :)

@housseindjirdeh
Copy link
Member

Thank you @kodisto 🙏 Only thing is the flag emoticon, everything else looks solid 🎉

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you 🙌

@housseindjirdeh housseindjirdeh merged commit 9b6f5b4 into gitpoint:master Oct 14, 2017
@chinesedfan
Copy link
Member

@housseindjirdeh This PR breaks ESLint. I will fix it in #478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants