Skip to content

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 18, 2025

Description

This PR does two things:

  1. Rename ReadinessController to StartupController and mount it on /startup, because it's used by the StartupProbe
  2. Introduce a fresh ReadinessController which:
    • always returns 👍
    • except when we already received SIGTERM, switching to 👎

Related Issue(s)

Fixes CLC-1234

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

geropl added 2 commits March 18, 2025 13:15
…r (because it's used by the StartupProbe)

Tool: gitpod/catfood.gitpod.cloud
…uring the shutdown phase

Tool: gitpod/catfood.gitpod.cloud
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geropl
Copy link
Member Author

geropl commented Mar 18, 2025

/unhold

@roboquat roboquat merged commit aaa27c2 into main Mar 18, 2025
46 checks passed
@roboquat roboquat deleted the gpl/1234-smooth-shutdown branch March 18, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants