-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[server] audit log service #19917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] audit log service #19917
Conversation
904b7f8
to
0762409
Compare
4ca0e54
to
dfeceb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look at the code and left some comments. I am happy to test and have signed up in the preview environment.
b540867
to
fabe902
Compare
@svenefftinge can you do that for me 🙏🏼 temp orgId: |
@Siddhant-K-code @filiptronicek I changed your users to enable audit logs You can try the API with this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can get audit logs correctly for basically everything I did in the preview environment, it's very nice.
I assume the next step is filtering this down to non-personal write events? Do we have a ticket for that?
{
"pagination": {
"total": 118
},
"auditLogs": [
{
"id": "5c62c015-834d-45a6-9090-07716335e22a",
"timestamp": "2024-06-24T14:16:40.612Z",
"action": "gitpod.v1.OrganizationService/listOrganizationMembers",
"organizationId": "1ea2a67e-cc3a-468a-b776-30fe0504f201",
"actorId": "010529b6-17e5-4289-b9e5-7446e9393164",
"args": "[{\"pagination\":{\"page\":0,\"token\":\"\",\"pageSize\":1000},\"organizationId\":\"1ea2a67e-cc3a-468a-b776-30fe0504f201\"}]"
},
{
"id": "f1464525-8f33-4f05-97d8-5862dda4bae1",
"timestamp": "2024-06-24T14:16:40.611Z",
"action": "gitpod.v1.OrganizationService/getOrganizationInvitation",
"organizationId": "1ea2a67e-cc3a-468a-b776-30fe0504f201",
"actorId": "010529b6-17e5-4289-b9e5-7446e9393164",
"args": "[{\"organizationId\":\"1ea2a67e-cc3a-468a-b776-30fe0504f201\"}]"
},
{
"id": "47dc651d-f6f9-4e20-9491-94584afdb007",
"timestamp": "2024-06-24T14:16:39.465Z",
"action": "gitpod.v1.WorkspaceService/listWorkspaces",
"organizationId": "1ea2a67e-cc3a-468a-b776-30fe0504f201",
"actorId": "010529b6-17e5-4289-b9e5-7446e9393164",
"args": "[{\"pinned\":true,\"pagination\":{\"page\":0,\"token\":\"\",\"pageSize\":50},\"searchTerm\":\"\",\"organizationId\":\"1ea2a67e-cc3a-468a-b776-30fe0504f201\"}]"
},
]
}
d6fe2ec
to
55d374d
Compare
55d374d
to
c79b74a
Compare
/unhold |
Description
Introduces generic audit logging, that can be turned on through a feature flag.
It only works for user that have an organizationId. For testing you need to manually update the db entry and then log out and in again.
Just ping me after you signed up and I will do that for you.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold