Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix error handling of repo APIs #198

Merged
merged 23 commits into from
Oct 31, 2021
Merged

Fix error handling of repo APIs #198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3a02a1d
Add a new error code
Oct 31, 2021
9cc573b
Fix error handling for approval
Oct 31, 2021
e0c783c
Fix handling errors for branch
Oct 31, 2021
7bde28a
Fix handling errros for commit
Oct 31, 2021
3f48061
Fix handling error for deployment
Oct 31, 2021
f59d9f0
Fix error handling for lock
Oct 31, 2021
ce419f3
Fix the error message
Oct 31, 2021
540791f
Fix handling errors for perm
Oct 31, 2021
921636e
Fix handling error for repo
Oct 31, 2021
cc8e1ca
Fix test
Oct 31, 2021
dfeacf4
Fix bugs
Oct 31, 2021
c599422
Add validation to store
Oct 31, 2021
337d805
Fix handling errors for OSS
Oct 31, 2021
e82e36f
Fix handling errors for stream
Oct 31, 2021
a2ea1de
Fix error handling for sycn
Oct 31, 2021
902841f
Fix error handling for user
Oct 31, 2021
e9ab78a
Fix error handling for hook
Oct 31, 2021
b91a9e5
Fix the error message.
Oct 31, 2021
5123054
Fix error handling for search
Oct 31, 2021
b97d49f
Fix error handling for middlewares
Oct 31, 2021
bb4f280
Remove config_not_found error
Oct 31, 2021
a874e97
wip
Oct 31, 2021
d2d3447
Fix dynamic logger.
Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the error message
  • Loading branch information
noah committed Oct 31, 2021
commit ce419f3ffd55eb15ec6ad98fa14e851aaa171dcd
8 changes: 4 additions & 4 deletions internal/server/api/v1/repos/approval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (r *Repo) GetMyApproval(c *gin.Context) {
if number, err = strconv.Atoi(c.Param("number")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", nil),
)
return
}
Expand Down Expand Up @@ -128,7 +128,7 @@ func (r *Repo) CreateApproval(c *gin.Context) {
if number, err = strconv.Atoi(c.Param("number")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", nil),
)
return
}
Expand Down Expand Up @@ -214,7 +214,7 @@ func (r *Repo) UpdateMyApproval(c *gin.Context) {
if number, err = strconv.Atoi(c.Param("number")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", nil),
)
return
}
Expand Down Expand Up @@ -282,7 +282,7 @@ func (r *Repo) DeleteApproval(c *gin.Context) {
if aid, err = strconv.Atoi(c.Param("aid")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", nil),
)
return
}
Expand Down
6 changes: 3 additions & 3 deletions internal/server/api/v1/repos/comment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func (r *Repo) ListComments(c *gin.Context) {
if number, err = strconv.Atoi(c.Param("number")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", nil),
)
return
}
Expand Down Expand Up @@ -72,7 +72,7 @@ func (r *Repo) GetComment(c *gin.Context) {
if id, err = strconv.Atoi(c.Param("id")); err != nil {
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The id must be integer.", nil),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The id must be number.", nil),
)
return
}
Expand All @@ -99,7 +99,7 @@ func (r *Repo) CreateComment(c *gin.Context) {
r.log.Warn("Failed to parse 'number'.", zap.Error(err))
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be integer.", err),
e.NewErrorWithMessage(e.ErrorCodeInvalidRequest, "The number must be number.", err),
)
return
}
Expand Down
15 changes: 12 additions & 3 deletions internal/server/api/v1/repos/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ func (r *Repo) CreateDeployment(c *gin.Context) {
var env *vo.Env
if env = cf.GetEnv(p.Env); env == nil {
r.log.Warn("The environment is not defined in the configuration.")
gb.ResponseWithStatusAndError(c, http.StatusUnprocessableEntity, err)
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeConfigParseError, "The environment is not defiend in the configuration.", nil),
)
return
}

Expand Down Expand Up @@ -190,7 +193,10 @@ func (r *Repo) UpdateDeployment(c *gin.Context) {
var env *vo.Env
if env = cf.GetEnv(d.Env); env == nil {
r.log.Warn("The environment is not defined in the configuration.")
gb.ResponseWithStatusAndError(c, http.StatusUnprocessableEntity, err)
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeConfigParseError, "The environment is not defiend in the configuration.", nil),
)
return
}

Expand Down Expand Up @@ -259,7 +265,10 @@ func (r *Repo) RollbackDeployment(c *gin.Context) {
var env *vo.Env
if env = cf.GetEnv(d.Env); env == nil {
r.log.Warn("The environment is not defined in the configuration.")
gb.ResponseWithStatusAndError(c, http.StatusUnprocessableEntity, err)
gb.ResponseWithError(
c,
e.NewErrorWithMessage(e.ErrorCodeConfigParseError, "The environment is not defiend in the configuration.", nil),
)
return
}

Expand Down