Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/core/git.js
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ Git.prototype.alterGitConfig = function (path, opts) {
concatConfig('merge.tool', opts.mergeTool);

if (wos.isWindows()) {
concatConfig(`mergetool.${opts.mergeTool}.cmd`, `'${opts.mergeTool}.exe $PWD/$LOCAL $PDW/$MERGED $PWD/$REMOTE'`);
concatConfig(`mergetool.${opts.mergeTool}.cmd`, `\"${opts.mergeTool}.exe $PWD/$LOCAL $PDW/$MERGED $PWD/$REMOTE\"`);
concatConfig(`mergetool.${opts.mergeTool}.trustExitCode`, 'true');
} else {
concatConfig(`mergetool.${opts.mergeTool}.cmd`, `'${opts.mergeTool} "$LOCAL" "$MERGED" "$REMOTE"'`);
Expand Down
14 changes: 14 additions & 0 deletions app/frontend/global/notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class GPNotification {
this.showLoad = opts.showLoad;
this.notificationElement = null;
this.autoclose = opts.autoclose;
this.closable = opts.closable;
}

pop() {
Expand Down Expand Up @@ -56,6 +57,19 @@ class GPNotification {
}

this.notificationElement.innerHTML += `<section class="content">${bodyText || titleText}</section>`;

if (this.closable) {
let closeBtn = document.createElement('button');

closeBtn.className = 'close-button';
closeBtn.title = MSGS.Close;
closeBtn.innerHTML = '<span class="octicon octicon-x"></span>';
closeBtn.onclick = function () {
this.close();
}.bind(this);

this.notificationElement.appendChild(closeBtn);
}

container.appendChild(this.notificationElement);

Expand Down
8 changes: 6 additions & 2 deletions app/frontend/modules/settings-page.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict';

(function () {

angular.module('settings', []).directive('settingsPage', function () {
Expand All @@ -24,6 +26,8 @@
{ code: 'en', description: 'English'},
{ code: 'pt-BR', description: 'Portuguese (Brazil)'}
];

this.appVersion = require('./package').version;

this.hideSettingsPage = function () {
this.showSettingsPage = false;
Expand All @@ -36,9 +40,9 @@

this.getGlobalGitConfigs = function () {
GIT.getGlobalConfigs(function (err, configs) {

if (err) {
alert(err.message);
new GPNotification(MSGS['It seems that a git username and email are not set globally. You can fix this accessing the Settings menu'], { closable: true }).pop();
} else {
this.globalGitConfigs = configs;
}
Expand Down
7 changes: 7 additions & 0 deletions app/frontend/view/content/settings-page.html
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@
<li>{{ MSGS.SettingsPage["GitPie is an open source git client that have the goal to be the most simple and nice client for any project and for any people"] }}</li>
</ul>
</li>

<li>
<div class="label">{{ MSGS.SettingsPage.Version }}</div>
<ul>
<li>{{ settingsCtrl.appVersion }}</li>
</ul>
</li>

<li>
<div class="label">{{ MSGS.SettingsPage.License }}</div>
Expand Down
5 changes: 4 additions & 1 deletion language/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@
"It happends with me all the time too. But lets's try find your project again!": "It happends with me all the time too. But let's try find your project again!",
"Start adding, clonning or creating some awesome things": "Start adding, clonning or creating some awesome things",
"Nothing for me here.\n The folder {folder} is not a git project": "Nothing for me here.\n The folder {folder} is not a git project",
"Close": "Close",
"It seems that a git username and email are not set globally. You can fix this accessing the Settings menu": "It seems that a git username and email are not set globally. You can fix this accessing the Settings menu",

"Error counting commits. Error: ": "Error counting commits. Error: ",
"Error adding files. Error:": "Error adding files. Error:",
Expand Down Expand Up @@ -143,7 +145,8 @@
"Navigate between repositories top to bottom": "Navigate between repositories top to bottom",
"Navigate between repositories bottom to top": "Navigate between repositories bottom to top",
"Add focus on the \"Search repositories\" field": "Add focus on the \"Search repositories\" field",
"Close modal windows and header menus": "Close modal windows and header menus"
"Close modal windows and header menus": "Close modal windows and header menus",
"Version": "Version"
},

"Authentication required": "Authentication required",
Expand Down
5 changes: 4 additions & 1 deletion language/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@
"It happends with me all the time too. But lets's try find your project again!": "Isso acontece comigo o tempo todo. Mas vamos tentar achar o seu projeto de novo!",
"Start adding, clonning or creating some awesome things": "Comece adicionando, clonando ou criando coisas incríveis",
"Nothing for me here.\n The folder {folder} is not a git project": "Nada pra mim aqui.\n A pasta {folder} não é um projeto git",
"Close": "Fechar",
"It seems that a git username and email are not set globally. You can fix this accessing the Settings menu": "Parece que um usuário e email git não estão definidos globalmente. Você pode corrigir isso acessando o menu de Configurações",

"Error counting commits. Error: ": "Erro contando commits. Erro: ",
"Error adding files. Error:": "Erro adicionando arquivos. Erro:",
Expand Down Expand Up @@ -143,7 +145,8 @@
"Navigate between repositories top to bottom": "Navega entre os repositórios de cima para baixo",
"Navigate between repositories bottom to top": "Navega entre os repositórios de baixo para cima",
"Add focus on the \"Search repositories\" field": "Adiciona foco no campo \"Procurar repositórios\"",
"Close modal windows and header menus": "Fecha janelas modais e menus de cabeçalho"
"Close modal windows and header menus": "Fecha janelas modais e menus de cabeçalho",
"Version": "Versão"
},

"Authentication required": "Autenticação requerida",
Expand Down
16 changes: 16 additions & 0 deletions resources/sass/all.scss
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,22 @@ body {
.content {
flex: 1 1 auto;
}

.close-button {
padding: 0;
padding-left: 20px;
padding-right: 10px;
color: #FFF;
background-color: #404040;
border: 0;
box-shadow: none;
cursor: pointer;
transition: color ease 0.2s;

&:hover {
color: rgba(255, 255, 255, 0.7);
}
}
}

/* Header of the application */
Expand Down