Skip to content

Adding new Helm charts with Examples #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adding new Helm charts with Examples #21

wants to merge 8 commits into from

Conversation

markoskandylis
Copy link

Adding new charts:

  • applciationsets helm chart with a folder examples of how to use it for versioning
  • fleet-secret helm chart to add the functionality of multiple ECR repo conection and secret refresh

@markoskandylis
Creating a helm chart for application sets
7d2156f 
Signed-off-by: Markos Kandylis <markos_kandylis@hotmail.com>
@markoskandylis
Adding new application set helm chart with Examples of how to use usi…
0b0c975 
…ng versioning folder

Signed-off-by: Markos Kandylis <markos_kandylis@hotmail.com>
csantanapr
csantanapr requested changes Jun 11, 2025
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a third helm chart that should not be included "applicaton-sets copy"

@markoskandylis
Removed old chart
26901a5 
Signed-off-by: Markos Kandylis <markos_kandylis@hotmail.com>
@markoskandylis
Copy link
Author

Cleaned up the old chart

csantanapr
csantanapr requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the following:

  • version numbers
  • remove packages directory for each chart

markoskandylis and others added 5 commits June 13, 2025 07:29
@markoskandylis @csantanapr
Update charts/application-sets/Chart.yaml
ff54c9f 
Co-authored-by: Carlos Santana <csantana23@gmail.com>
@markoskandylis @csantanapr
Update charts/fleet-secret/Chart.yaml
1b38a1c 
Co-authored-by: Carlos Santana <csantana23@gmail.com>
@markoskandylis @csantanapr
Update charts/fleet-secret/Chart.yaml
f4bdcff 
Co-authored-by: Carlos Santana <csantana23@gmail.com>
@markoskandylis @csantanapr
Update charts/application-sets/Chart.yaml
920da7a 
Co-authored-by: Carlos Santana <csantana23@gmail.com>
@markoskandylis
Removed packages file
bb08729 
Signed-off-by: Markos Kandylis <markos_kandylis@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markoskandylis @csantanapr