Assign to variable to prevent null value #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandresalome
approved these changes
Mar 1, 2022
|
Thanks |
stof
reviewed
Jul 8, 2022
| @@ -90,8 +90,8 @@ protected function doParse() | |||
|
|
|||
| $oldName = $oldName === '/dev/null' ? null : substr($oldName, 2); | |||
| $newName = $newName === '/dev/null' ? null : substr($newName, 2); | |||
| $oldIndex !== null ?: ''; | |||
| $newIndex !== null ?: ''; | |||
| $oldIndex = $oldIndex !== null ?: ''; | |||
There was a problem hiding this comment.
The usage of ?: turns $oldIndex into a boolean when not null. This looks unexpected to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about this guys. My PHP 8.1 fix for not passing null was derailed by PHP 5.6 backport. I forgot to assign the value! AARRG!! I could have just put the expression into the function call directly, but I tend to do it outside, as I think it makes the code a little less complex and easier to read.
Again, my apologies.