Don't pass null as second parameter to preg_match #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you @phpfui ! |
|
Can we get a v1.3.4 tag for this? It is causing errors for me in production. Thanks! |
|
@phpfui done |
|
@alexandresalome I still don't see a v1.3.4 version of this library. Did a tag not get pushed? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this on my website where I access git commits as a diff. PHPFUI/Instadoc click on the top two commits to see the error in the wild. Will be fixed automatically when this PR is published. Site updates nightly.
This is just an 8.1 issue.
There may be other places this happens, but I have only run into this one.