No commit message = issues

[philipmclifton]

Very rare, but possible.

When logging a repository that has a commit with no commit message.

$this->content = 


commit 4d58c86cfbe69bba817775ca13794c6ef4543d7e
tree 501a51b6fd37ca3486346439e9f6866168aa1e19
parent 650670073cf5051d00421f59f001c58f6fe741bf
parent 31ab9665b96a85b887c362e39362d4530e9ab338
author philipclifton <me@philipmclifton.com> 1400586247 +0100
committer philipclifton <me@philipmclifton.com> 1400586247 +0100

    Merge remote-tracking branch 'origin/staging' into staging

commit 650670073cf5051d00421f59f001c58f6fe741bf
tree dcaeb301cef9ea57fc6dd1959bcf1026c9af205c
parent d4fcb008a822da8e777612cdf7013a7eae1df827
author philipclifton <me@philipmclifton.com> 1400586096 +0100
committer philipclifton <me@philipmclifton.com> 1400586096 +0100

    add crons

commit 31ab9665b96a85b887c362e39362d4530e9ab338
tree c8a4523947be4f8f7ee98e49be041929a8b2cba8
parent d4fcb008a822da8e777612cdf7013a7eae1df827
author Andy Gilbert <andy@callan.co.uk> 1400585521 +0000
committer Andy Gilbert <andy@callan.co.uk> 1400585521 +0000

commit d4fcb008a822da8e777612cdf7013a7eae1df827
tree b35fdabaac1d5a5572aa82fd7ded9e05a9c3bd23
parent 766e51ae4d27bb0abbe6707950fa7962221e184b
author philipclifton <me@philipmclifton.com> 1400577338 +0100
committer philipclifton <me@philipmclifton.com> 1400577338 +0100

    change contact phone number

commit 766e51ae4d27bb0abbe6707950fa7962221e184b
tree 446f561a9c0e1e46a30e27f0f5caf73438739d24
parent 3bae15039da08833d69b3c096c4d9936fcfc38cb
author philipclifton <me@philipmclifton.com> 1400505454 +0100
committer philipclifton <me@philipmclifton.com> 1400505454 +0100

    fix the line effecting the sagepay gateway.

    It now compares the price with or without taxes with the amount paid

commit 3bae15039da08833d69b3c096c4d9936fcfc38cb
tree 8875da1842ef585da44fefa65c0dee9afd26a44c
parent c69ea07c352e40a9ec74af8e900f2bf8f95b665b
author philipclifton <me@philipmclifton.com> 1400497827 +0100
committer philipclifton <me@philipmclifton.com> 1400497827 +0100

    fix error in url

commit c69ea07c352e40a9ec74af8e900f2bf8f95b665b
tree 0cb3cc9ab731a423bb083a3dde6c0a245e642228
parent 048e82e03873cec8f2b96fa98add1ca5ddca8dca
author philipclifton <me@philipmclifton.com> 1400497435 +0100
committer philipclifton <me@philipmclifton.com> 1400497435 +0100

    remove debug

commit 048e82e03873cec8f2b96fa98add1ca5ddca8dca
tree 42f1581b49e40e57df31c9031b30b39480f90c0d
parent d2f475a82879d4d8847166e3932bdf9543b20b26
author philipclifton <me@philipmclifton.com> 1400497322 +0100
committer philipclifton <me@philipmclifton.com> 1400497322 +0100

    remove debug

commit d2f475a82879d4d8847166e3932bdf9543b20b26
tree 7efb534b7c416edd4298d26a6f822c56cfa54201
parent 747c52612761aecc92973459d4e14f6f069bbe61
author philipclifton <me@philipmclifton.com> 1400496997 +0100
committer philipclifton <me@philipmclifton.com> 1400496997 +0100

    debug

commit 747c52612761aecc92973459d4e14f6f069bbe61
tree 42f1581b49e40e57df31c9031b30b39480f90c0d
parent c47ef1e1e0780adb5cee513265f75640f10a27e4
author philipclifton <me@philipmclifton.com> 1400495969 +0100
committer philipclifton <me@philipmclifton.com> 1400495969 +0100

[AndrejAndb]

up!
as temporary solution - my fix:

https://github.com/gitonomy/gitlib/blob/master/src/Gitonomy/Git/Parser/LogParser.php#L55

if (!$this->isFinished()) {
    if (!$this->expects('commit ')) {
        $this->consumeNewLine();
    } else {
        $this->cursor -= strlen('commit ');
    }
}

[alexandresalome]

It needs a proper PR

[GrahamCampbell]

Ping @philipmclifton, @AndrejAndb.

[tolik518]

I can't seem to reproduce the exception (yet).
I'll take a deeper look sometime this week again and I'll report back.

Edit:
This seems to have been fixed a while ago, I added some regression tests in the pull request #196