This repository has been archived by the owner on Apr 27, 2024. It is now read-only.
Split refactor api #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max104t
force-pushed
the
split-refactor-api
branch
2 times, most recently
from
4a561d9
to
d1fe47b
Compare
|
rebased on latest master |
|
This recent change breaks up the TestApi view and controller into their own files |
Max104t
force-pushed
the
split-refactor-api
branch
2 times, most recently
from
c545c72
to
7a0e8d0
Compare
testing: few clicks in the product.. V1, V2 seems to work
TODO: move to upstream repo gitnew2018/My-OpenPeriscope/master after merge
Max104t
force-pushed
the
split-refactor-api
branch
from
dca9668
to
eff34d9
Compare
gitnew2018
suggested changes
Aug 16, 2019
Max104t
force-pushed
the
split-refactor-api
branch
from
3ce7bb2
to
4fe06d5
Compare
|
Round 2: I think I've addresses the feedback.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to split the code.. first step the Periscope API.. it is separated into ./PeriscopeWrapper.js with potential more code move like the login etc.
Notes:
. To minimize merge work, this change is rebased on top of HTML method pull request : #38
Testing:
. opened
Top,ApiTest, andFollowingall seem to work fineTODO:
. change the
@requiretag after merge to point to the original repository