Skip to content

feat: reflect_scars tool + default execution_successful at close#16

Merged
CLCrawford-dev merged 1 commit intomainfrom
feature/od-772-reflect-scars-enforcement-gap
Feb 21, 2026
Merged

feat: reflect_scars tool + default execution_successful at close#16
CLCrawford-dev merged 1 commit intomainfrom
feature/od-772-reflect-scars-enforcement-gap

Conversation

@nTEG-dev
Copy link
Member

Summary

  • Option A: session_close now defaults execution_successful based on confirm_scars decision — APPLYING scars default to true, unmentioned scars default to false. Fixes the 80% null rate in scar_usage records.
  • Option B: New reflect_scars tool (gitmem-rf / gm-reflect) for end-of-session OBEYED/REFUTED evidence with minimum evidence thresholds. Reflections are bridged into scar_usage at close with priority over Option A defaults.
  • Closes the scar enforcement gap where agents confirm scars but never report outcomes, causing misleading 33% success rate in analytics.

Changes

File What
src/tools/reflect-scars.ts New tool — validates reflections, persists to session state + file
src/tools/session-close.ts Bridges reflections into scar_usage; defaults execution_successful
src/tools/definitions.ts Tool definition + gitmem-rf / gm-reflect aliases
src/server.ts Routing + help entry
src/services/session-state.ts addReflections() / getReflections()
src/services/metrics.ts reflect_scars in ToolName + performance target
src/types/index.ts ScarReflection, ReflectScarsParams, ReflectScarsResult types

Test plan

  • Build passes (tsc clean)
  • All 865 tests pass
  • Manual E2E: session_startrecallconfirm_scars → work → reflect_scarssession_close — verify scar_usage records have execution_successful populated
  • Verify Option A defaults work when reflect_scars is NOT called
  • Verify Option B reflections override Option A defaults when both exist

Refs: OD-772

🤖 Generated with Claude Code

…ion close

Close the scar enforcement gap where agents confirm scars (APPLYING) but
never report outcomes, causing 80% null execution_successful in scar_usage.

Option A: session_close defaults execution_successful based on confirm_scars
decision (APPLYING→true, unmentioned→false).

Option B: new reflect_scars tool (gitmem-rf/gm-reflect) for end-of-session
OBEYED/REFUTED evidence, bridged into scar_usage with priority over defaults.

Refs: OD-772

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CLCrawford-dev CLCrawford-dev merged commit 75d7e1b into main Feb 21, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants