Skip to content

Remove duplicates members in child classes, add "@Override" annotation #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public String toValue() {
return (enumHelper.toString(this));
}

@Override
public String toString() {
return (enumHelper.toString(this));
}
Expand Down Expand Up @@ -241,6 +242,7 @@ public String getLinkByName(String name) {
return (links.get(name));
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public void setUrl(String url) {
this.url = url;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public class ChildEpic extends AbstractEpic<ChildEpic> {
private static final long serialVersionUID = 1L;

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ public class CreatedChildEpic extends AbstractMinimalEpic<CreatedChildEpic> {

private Boolean hasChildren;
private Boolean hasIssues;
private String url;
private String relationUrl;

public Boolean getHasChildren() {
Expand All @@ -26,14 +25,6 @@ public void setHasIssues(Boolean hasIssues) {
this.hasIssues = hasIssues;
}

public String getUrl() {
return url;
}

public void setUrl(String url) {
this.url = url;
}

public String getRelationUrl() {
return relationUrl;
}
Expand All @@ -42,6 +33,7 @@ public void setRelationUrl(String relationUrl) {
this.relationUrl = relationUrl;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public void setSubscribed(Boolean subscribed) {
this.subscribed = subscribed;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public class EpicInLink extends AbstractEpic<EpicInLink> {
private static final long serialVersionUID = 1L;

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public class IssueEpic extends AbstractMinimalEpic<IssueEpic> {
private static final long serialVersionUID = 1L;

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public void setLinkUpdatedAt(Date linkUpdatedAt) {
this.linkUpdatedAt = linkUpdatedAt;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public void setUpdatedAt(Date updatedAt) {
this.updatedAt = updatedAt;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public enum Type {
BLOB,
COMMIT;

@Override
public String toString() {
return (name().toLowerCase());
}
Expand Down
14 changes: 0 additions & 14 deletions gitlab4j-models/src/main/java/org/gitlab4j/api/models/User.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public class User extends AbstractUser<User> {
private String publicEmail;
private Integer sharedRunnersMinutesLimit;
private String skype;
private String state;
private Integer themeId;
private String twitter;
private Boolean twoFactorEnabled;
Expand Down Expand Up @@ -232,14 +231,6 @@ public void setSkype(String skype) {
this.skype = skype;
}

public String getState() {
return state;
}

public void setState(String state) {
this.state = state;
}

public Integer getThemeId() {
return themeId;
}
Expand Down Expand Up @@ -398,11 +389,6 @@ public User withSkype(String skype) {
return this;
}

public User withState(String state) {
this.state = state;
return this;
}

public User withThemeId(Integer themeId) {
this.themeId = themeId;
return this;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ public class HipChatService extends NotificationService {
public static final String ROOM_PROP = "room";
public static final String API_VERSION_PROP = "api_version";
public static final String SERVER_PROP = "server";
public static final String NOTIFY_ONLY_BROKEN_PIPELINES_PROP = "notify_only_broken_pipelines";

/**
* Get the form data for this service based on it's properties.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class JiraService extends NotificationService {
public static final String URL_PROP = "url";
public static final String API_URL_PROP = "api_url";
public static final String PROJECT_KEY_PROP = "project_key";
public static final String USERNAME_PROP = "username";
public static final String JIRA_ISSUE_TRANSITION_ID_PROP = "jira_issue_transition_id";
public static final String COMMIT_EVENTS_PROP = "commit_events";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ public class MergeRequestSystemHookEvent extends MergeRequestEvent implements Sy
public static final String X_GITLAB_EVENT = "System Hook";
public static final String MERGE_REQUEST_EVENT = "merge_request";

private String eventType;
private String eventName;

@Override
Expand All @@ -27,14 +26,6 @@ public void setEventName(String eventName) {
this.eventName = eventName;
}

public String getEventType() {
return eventType;
}

public void setEventType(String eventType) {
this.eventType = eventType;
}

/**
* @deprecated use {@link #setEventType(String)} instead
* @param eventType
Expand Down
Loading