-
Notifications
You must be signed in to change notification settings - Fork 279
feat: working electron-vite config #2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
src/renderer/App.css
Outdated
| @import "@primer/css/dist/primer.css"; | ||
|
|
||
| /** Tailwind CSS Configuration */ | ||
| @config '../../tailwind.config.ts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It it possible to make the tailwind change separately, to reduce complexity and risk for both vite and tailwind changes?
|
I have a working project with electron-vite in use. I'm not super experienced with it, but may be able to help if you run into something tricky. |
The goal was to simply simplify the project as webpack does present its challenges, so hopefully less tricky things will appear 🙏 |
|





This pull request migrates the Electron app's build system from Webpack to electron-vite, resulting in a significant simplification of the configuration files and build scripts. It removes all Webpack-related configuration and dependencies, introduces new vite-based configuration, and updates file paths and environment variable handling throughout the codebase. Additionally, the CSS and asset handling are modernized to work with Vite and Tailwind v4 (no need for a config file), and logger usage is improved for better compatibility between main and renderer processes.
At the current state however, Primer's variables are being loaded, but somehow not used yet.