Skip to content

refactor: resolve sonar feedback re login fn #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

refactor: resolve sonar feedback re login fn #1823

merged 1 commit into from
Feb 8, 2025

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 7, 2025 •
edited
Loading

@setchy
fix: sonar issue with login
6919e0a 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 6.1.0 milestone Feb 7, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy changed the title fix: sonar issue with login refactor: address sonar issue with login Feb 7, 2025
@github-actions github-actions bot added refactor Refactoring of existing feature and removed bug Something isn't working labels Feb 7, 2025
@setchy setchy changed the title refactor: address sonar issue with login refactor: resolve sonar feedback re login fn Feb 7, 2025
@setchy setchy merged commit 01db9b1 into main Feb 8, 2025
21 checks passed
@setchy setchy deleted the fix/login-sonar-issue branch February 8, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 6.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@setchy