Skip to content

fix: page layouts #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const App = () => {
<BaseStyles>
<AppProvider>
<Router>
<div className="flex h-full overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
<div className="flex h-screen overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
<Loading />
<Sidebar />
<Routes>
Expand Down
5 changes: 5 additions & 0 deletions src/renderer/components/Oops.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { render } from '@testing-library/react';
import { ensureStableEmojis } from '../__mocks__/utils';
import { Oops } from './Oops';

describe('renderer/components/Oops.tsx', () => {
beforeEach(() => {
ensureStableEmojis();
});

it('should render itself & its children - specified error', () => {
const mockError = {
title: 'Error title',
Expand Down
8 changes: 4 additions & 4 deletions src/renderer/components/__snapshots__/AllRead.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions src/renderer/components/__snapshots__/Oops.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/renderer/components/layout/Centered.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const Centered: FC<ICentered> = ({
align="center"
justify="center"
padding="spacious"
className={fullHeight && 'min-h-screen'}
className={fullHeight && 'h-full'}
>
{props.children}
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/layout/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface IPage {

export const Page: FC<IPage> = (props: IPage) => {
return (
<div className="flex flex-col h-screen" data-testid={props.id}>
<div className="flex flex-col h-full" data-testid={props.id}>
{props.children}
</div>
);
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/renderer/routes/LoginWithOAuthApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export const LoginWithOAuthAppRoute: FC = () => {

return (
<Page id="Login With OAuth App">
<form onSubmit={handleSubmit}>
<form onSubmit={handleSubmit} className="-mt-5">
<FieldInput
name="hostname"
label="Hostname"
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/routes/__snapshots__/Filters.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/renderer/routes/__snapshots__/Login.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/renderer/routes/__snapshots__/Settings.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading