GP-1963 handle default pointer replacement

githuu5y5u · Apr 27, 2022 · c38f202 · c38f202
1 parent 2a34f20
commit c38f202
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/Ghidra/Features/Base/ghidra_scripts/FixElfExternalOffsetDataRelocationScript.java b/Ghidra/Features/Base/ghidra_scripts/FixElfExternalOffsetDataRelocationScript.java
@@ -129,7 +129,8 @@ else if (signChar != '+') {
 		}
 
 		DataType dt = data.getDataType();
-		boolean isDefaultTypeApplied = Undefined.isUndefined(dt);
+		boolean isDefaultTypeApplied = address.equals(data.getAddress()) &&
+			(Undefined.isUndefined(dt) || isDefaultPointer(dt));
 		int componentOffset = (int) address.subtract(data.getAddress());
 		if (!isDefaultTypeApplied &&
 			!canFixupStructure(dt, componentOffset, address.getPointerSize())) {
@@ -175,6 +176,14 @@ else if (signChar != '+') {
 		return true;
 	}
 
+	private boolean isDefaultPointer(DataType dt) {
+		if (dt instanceof Pointer) {
+			DataType refDt = ((Pointer) dt).getDataType();
+			return refDt == null || refDt == DataType.DEFAULT;
+		}
+		return false;
+	}
+
 	private boolean canFixupStructure(DataType dt, int componentOffset, int pointerLength) {
 		if (!(dt instanceof Structure)) {
 			return false;