Skip to content

Improved tab bar scrolling #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubuser0xFFFF merged 2 commits into from
Dec 12, 2024
Merged

Improved tab bar scrolling #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec437cd
Improved tab bar scrolling
Servall4 Nov 27, 2024
e21c302
Fix: tab bar scroll for mouse
Servall4 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/DockAreaTabBar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,19 +160,9 @@ CDockAreaTabBar::~CDockAreaTabBar()
//============================================================================
void CDockAreaTabBar::wheelEvent(QWheelEvent* Event)
{
Event->accept();
const int direction = Event->angleDelta().y();
if (direction < 0)
{
horizontalScrollBar()->setValue(horizontalScrollBar()->value() + 20);
}
else
{
horizontalScrollBar()->setValue(horizontalScrollBar()->value() - 20);
}
QCoreApplication::sendEvent(horizontalScrollBar(), Event);
}


//============================================================================
void CDockAreaTabBar::setCurrentIndex(int index)
{
Expand Down Expand Up @@ -356,7 +346,7 @@ void CDockAreaTabBar::onCloseOtherTabsRequested()
CDockWidget::DockWidgetDeleteOnClose) ? 1 : 0;
closeTab(i);

// If the the dock widget blocks closing, i.e. if the flag
// If the dock widget blocks closing, i.e. if the flag
// CustomCloseHandling is set, and the dock widget is still open,
// then we do not need to correct the index
if (Tab->dockWidget()->isClosed())
Expand Down
3 changes: 1 addition & 2 deletions src/DockAreaTabBar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ private Q_SLOTS:
void onTabWidgetMoved(const QPoint& GlobalPos);

protected:
virtual void wheelEvent(QWheelEvent* Event) override;

virtual void wheelEvent(QWheelEvent* Event) override;

public:
using Super = QScrollArea;
Expand Down