-
Notifications
You must be signed in to change notification settings - Fork 668
Improve safety in code #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve safety in code #588
Conversation
40f6d5e to
b3e65a8
Compare
|
@tmartsum Thank you for this pull request. I just reviewed it and it looks good for me. Just a wish regarding coding style: Instead of: if (!DockArea) continue;or if (!DockArea) {
continue;
}I would prefer the following style: always brackets and the opening bracket on a new line if (!DockArea)
{
continue;
}Just in case you would like to provide more pull requests 😏. It would be great, if you could polish this pull request to match this style. |
Delete areas later so that that they can be accessed by (inherited) dock widgets in dtor. Add some QPointer to prevent crashes. Hence allow users to do more while dock widgets etc are being destroyed.
b3e65a8 to
7a110b8
Compare
|
Hi Uwe I did try to fit style (e.g by using tabs though most code-bases in both Luxion and Qt are using spaces), but I may not have cought all aspects and habbits can be difficult to change 😉 - just poke me in the future MRs if I do any mistakes include styling. I can however see, that others are contributing with spaces, but I suspect you prefer tabs in the project? Best Regards |
githubuser0xFFFF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my review comments - thank you.
| const QList<CFloatingDockContainer*> CDockManager::floatingWidgets() const | ||
| { | ||
| return d->FloatingWidgets; | ||
| QList<CFloatingDockContainer*> res; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to return a const QList<QPointer<CFloatingDockDontainer>> here because the function floatingWidgets() is used in CDockManager::eventFilter on linux. So this change may have a negative performance impact because it is called very often.
|
Thank you. I merged your pull request. |
Delete areas later so that that they can be accessed by (inherited) dock widgets in dtor. Add some QPointer to prevent crashes. Hence allow users to do more while dock widgets etc are being destroyed.
Delete areas later so that that they can be accessed by (inherited) dock widgets in dtor. Add some QPointer to prevent crashes.
Hence allow users to do more while dock widgets etc are being destroyed.