Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Conversation

@parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Jan 14, 2020

Changes are now saved immediately after selecting a publishing source.

Official docs for reference: Configuring a publishing source for your GitHub Pages site.

Changes are now saved immediately after selecting a publishing source.
@github-learning-lab github-learning-lab bot had a problem deploying to production January 14, 2020 17:56 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production January 14, 2020 18:04 Failure
@parkerbxyz
Copy link
Contributor Author

I'm not sure why the deployments are failing, so I'm going to leave this PR in a draft state until someone tells me it is safe to merge.

@brianamarie
Copy link
Contributor

Hmm @parkerbxyz I'm not sure why the deploy is failing. @JasonEtco where can we look to get some more context on why this is failing? Could it be because it's a draft PR?

@parkerbxyz I think it's OK to try this as a non-draft PR to see if that affects the deploy. What do you think?

@parkerbxyz parkerbxyz marked this pull request as ready for review January 15, 2020 16:55
@github-learning-lab github-learning-lab bot had a problem deploying to production January 27, 2020 11:44 Failure
@brianamarie
Copy link
Contributor

I don't know what's up with the deploy message. I am able to access the deployed version of this branch: https://lab.github.com/githubtraining/securing-your-workflows/12.3.1-parkerbxyz-patch-1.0, and I'm also able to register for the course: brianamarie/security-on-github#2.

I say 🚢 this @parkerbxyz - worst case scenario is that it doesn't deploy, so it won't break anything that isn't already broken, and we can troubleshoot from there.

@parkerbxyz
Copy link
Contributor Author

Alright, I'll go ahead and merge. Thanks, @brianamarie!

@parkerbxyz parkerbxyz merged commit cf11492 into master Jan 27, 2020
@parkerbxyz parkerbxyz deleted the parkerbxyz-patch-1 branch January 27, 2020 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants