Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Briana edits #53

Merged
merged 15 commits into from
Aug 21, 2019
Merged

Briana edits #53

merged 15 commits into from
Aug 21, 2019

Conversation

brianamarie
Copy link
Contributor

Hi @hectorsector! I went through the course and decided it would be fastest for me to make direct edits to the responses. As always, please feel free to revert or change anything directly in this PR.

Some other things that are very notable:

  • I couldn't progress past step 5, because the verification kept saying I was doing the wrong thing, but I was following instructions. I decided to move past this and focus on responses instead of fixing the logic.
  • Q: In step 3, is the list component/child component a prop? How does the activity relate to the content at all in this step? The step and activity here aren't quite tied together enough, and I don't know enough about React to know if that's because some key vocabulary is missing, or because the steps aren't in the right place.

@github-learning-lab github-learning-lab bot temporarily deployed to production August 20, 2019 12:35 Inactive
@github-learning-lab
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI!

@github-learning-lab github-learning-lab bot temporarily deployed to production August 20, 2019 12:39 Inactive
@hectorsector
Copy link
Member

  • In step 3, is the list component/child component a prop? How does the activity relate to the content at all in this step? The step and activity here aren't quite tied together enough, and I don't know enough about React to know if that's because some key vocabulary is missing, or because the steps aren't in the right place.

Did this part come through in your repo @brianamarie? It provides me the explanation I need, but maybe it needs beefing up?

Now, let's discuss how we can reuse the same component with different properties.

That might sound a little confusing, but let's take a look. Go to our final solution and add some assignments along with students. You might start to notice that both lists look the same, but with different values. In fact, both lists are the same component!

How do we pass different values to a component? We pass properties to the component, otherwise known as props.

Take a look at our final solution for our assignments and students page above. You'll see that they look similar. The lists are the same component, but with different values. Next, we'll learn to pass different values to the same components.

Maybe the part that's missing is an explicit mention that the List component we'll import is the one that enables reuse? We can change this line:

In this step, we will import the List component that we created for you into App.

to:

In this step, we will import the List component that we created for you into App so you can take advantage of this reusability.

@hectorsector
Copy link
Member

  • I couldn't progress past step 5, because the verification kept saying I was doing the wrong thing, but I was following instructions. I decided to move past this and focus on responses instead of fixing the logic.

Tested and it worked for me. But there are a couple of things that could be confusing. Did you (or do you think that learners could) come across any of the following?

  • Editing App.jsx instead List.jsx
  • Editing line 30 instead of line 31

If neither of those things were issues, could you reproduce it and send me a link? It's likely the regex is missing the way you're doing it and I'd like to fix it.

@brianamarie
Copy link
Contributor Author

Did this part come through in your repo @brianamarie? It provides me the explanation I need, but maybe it needs beefing up?

@hectorsector The words I was looking for are "prop" in the "step 3" block. It's unclear to me if all children are props. There's component, prop, and child, and the way it is now feels a bit like the "If all Pleeps are Floops and all Floops are Leepies, then all Pleeps are definitely Leepies." question.

For the place I got stuck, @hectorsector the repo is private but I invited you to it.

Here's my commit where I edited line 31 of src/List.jsx: brianamarie/intro-react@21f68e8

And my subsequent commit where I tried to edit line 30 instead: brianamarie/intro-react@a1dd000

@hectorsector
Copy link
Member

hectorsector commented Aug 21, 2019

Thanks for inviting me to the repo, @brianamarie! I am specifically validating that {this.props.title} is within the <h2> tags. If you think it's easy to make this mistake, we can probably add it on its own line.

@github-learning-lab github-learning-lab bot temporarily deployed to production August 21, 2019 13:47 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production August 21, 2019 14:28 Inactive
Copy link
Member

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the contributions, @brianamarie! Feel free to 🚢 it.

@brianamarie brianamarie merged commit 98a4a4c into master Aug 21, 2019
@brianamarie brianamarie deleted the briana-edits branch August 21, 2019 15:20
@hectorsector hectorsector mentioned this pull request Aug 21, 2019
41 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants