-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Your draft course version was created!You can edit it using the Course Builder UI! |
Did this part come through in your repo @brianamarie? It provides me the explanation I need, but maybe it needs beefing up?
Maybe the part that's missing is an explicit mention that the List component we'll import is the one that enables reuse? We can change this line:
to:
|
Tested and it worked for me. But there are a couple of things that could be confusing. Did you (or do you think that learners could) come across any of the following?
If neither of those things were issues, could you reproduce it and send me a link? It's likely the regex is missing the way you're doing it and I'd like to fix it. |
@hectorsector The words I was looking for are "prop" in the "step 3" block. It's unclear to me if all children are props. There's For the place I got stuck, @hectorsector the repo is private but I invited you to it. Here's my commit where I edited line 31 of And my subsequent commit where I tried to edit line 30 instead: brianamarie/intro-react@a1dd000 |
Thanks for inviting me to the repo, @brianamarie! I am specifically validating that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the contributions, @brianamarie! Feel free to 🚢 it.
Hi @hectorsector! I went through the course and decided it would be fastest for me to make direct edits to the responses. As always, please feel free to revert or change anything directly in this PR.
Some other things that are very notable: