This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Broke Down State and CallBack Steps #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
temporarily deployed
to
production
hectorsector
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
One small change and then I think it's ready to 🚢 @partyshah
| @@ -130,13 +142,8 @@ steps: | |||
| file: src/App.jsx | |||
| position: 38 | |||
| pullRequest: '%actions.metaPR2.data.number%' | |||
There was a problem hiding this comment.
I don't know if this problem is introduced by this PR, but it's kind of awkward that this comment is dropped on a line without a code change. Can you reproduce this, @partyshah? I think this comment makes more sense if it's attached to the comment that describes the expected step (highlighter line on the screenshot below).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I: