Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Breaking down props and state exercises #25

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Breaking down props and state exercises #25

merged 7 commits into from
Jul 31, 2019

Conversation

partyshah
Copy link

This is not ready for review yet. In this PR I want to:

  • break down the props step into multiple steps
  • break down the states step into multiple steps

@ghost ghost had a problem deploying to production July 31, 2019 21:05 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production July 31, 2019 21:05 Failure
@ghost
Copy link

ghost commented Jul 31, 2019

🔴 There was an error parsing your config.yml file.

YAMLException: duplicated mapping key at line 71, column 9:
            pullRequest: '%actions.metaPR2.d ... 
            ^

1 similar comment
@github-learning-lab
Copy link

🔴 There was an error parsing your config.yml file.

YAMLException: duplicated mapping key at line 71, column 9:
            pullRequest: '%actions.metaPR2.d ... 
            ^

@ghost ghost temporarily deployed to production July 31, 2019 21:06 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 21:06 Inactive
@ghost ghost temporarily deployed to production July 31, 2019 22:38 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 22:38 Inactive
@ghost ghost temporarily deployed to production July 31, 2019 22:51 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 22:51 Inactive
@partyshah
Copy link
Author

@hectorsector ready for review!

Cleaned up the props instructions.

hectorsector
hectorsector suggested changes Jul 31, 2019
View reviewed changes
@hectorsector
Update config.yml
8244665 
Co-Authored-By: Hector Alfaro <hectorsector@github.com>
@ghost ghost temporarily deployed to production July 31, 2019 23:00 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 23:00 Inactive
hectorsector
hectorsector suggested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, @partyshah! Just some minor changes.

@hectorsector
Update responses/import-child-component-activity.md
e7a128a 
Co-Authored-By: Hector Alfaro <hectorsector@github.com>
@ghost ghost temporarily deployed to production July 31, 2019 23:44 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 23:44 Inactive
@hectorsector
Update responses/uncomment-assignments-activity.md
234d23b 
Co-Authored-By: Hector Alfaro <hectorsector@github.com>
@ghost ghost temporarily deployed to production July 31, 2019 23:44 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 23:44 Inactive
@ghost ghost temporarily deployed to production July 31, 2019 23:45 Inactive
@github-learning-lab github-learning-lab bot temporarily deployed to production July 31, 2019 23:45 Inactive
@partyshah partyshah merged commit fabd528 into master Jul 31, 2019
@hectorsector hectorsector deleted the props-state branch August 1, 2019 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectorsector hectorsector hectorsector requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@partyshah @hectorsector