adding branch protection #23
Conversation
ghost
temporarily deployed
to
production
|
Currently adding branch protection to first step and approving PR at the last step. Will notify when ready for review. |
🔴 2 errors found in the config file. |
1 similar comment
🔴 2 errors found in the config file. |
| - type: createReview | ||
| event: APPROVE | ||
| body: approve.md | ||
| pullRequest: Changes |
There was a problem hiding this comment.
We're attempting to provide a review on a closed pull request (see event: pull_request.closed). We can't approve a closed PR.
There was a problem hiding this comment.
Oh that makes sense. I'll change that to a push event. Thank you!
There was a problem hiding this comment.
You may want to add a step where the learner merges. It's incredibly satisfying for the learner to merge the PR they've been working on and you won't have to do it for them.
There was a problem hiding this comment.
That sounds good. Will add that step in this PR.
|
@hectorsector ready for review! In this PR, I did the following
|
There was a problem hiding this comment.
This is such an improved experience @partyshah! Feel free to 🚢 it.
|
Fixes #22 |
|
Closes #22 |
No description provided.