-
Notifications
You must be signed in to change notification settings - Fork 43
Update firewall to v0.9.0 with SSL Bump and URL path filtering support #9985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
…support Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
…SSLBumpArgs Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results - Copilot EngineLast 2 Merged PRs:
Test Results:
Overall Status: FAIL (1/5 tests failed) cc @Mossaka
|
Smoke Test Results - Claude EngineLast 2 Merged PRs:
Test Results:
Overall Status: PASS
|
|
@copilot these features are exclusive to awf firewall and not to the agent-sandbox. Can you be explicit about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the gh-aw-firewall to v0.9.0 and implements support for new SSL Bump and URL path filtering features. The update enables HTTPS content inspection and path-based filtering beyond domain-only restrictions.
Changes:
- Bumped default firewall version from v0.8.2 to v0.9.0
- Added
SSLBumpandAllowURLsfields toFirewallConfigstruct - Implemented
getSSLBumpArgs()helper function for consistent SSL Bump argument generation across all engines - Updated JSON schemas with validation patterns requiring
https://scheme for allowed URLs - Recompiled all workflow lock files to reference the new v0.9.0 version
Reviewed changes
Copilot reviewed 128 out of 128 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/constants.go | Updated DefaultFirewallVersion constant from v0.8.2 to v0.9.0 |
| pkg/workflow/firewall.go | Added SSLBump and AllowURLs fields to FirewallConfig struct and implemented getSSLBumpArgs() helper |
| pkg/workflow/firewall_test.go | Added comprehensive test suite for getSSLBumpArgs() function |
| pkg/workflow/firewall_args_test.go | Added integration tests verifying SSL Bump flags in AWF commands |
| pkg/workflow/copilot_engine_execution.go | Integrated getSSLBumpArgs() into Copilot engine execution |
| pkg/workflow/claude_engine.go | Integrated getSSLBumpArgs() into Claude engine execution |
| pkg/workflow/codex_engine.go | Integrated getSSLBumpArgs() into Codex engine execution |
| pkg/parser/schemas/*.json | Added ssl-bump and allow-urls schema properties with validation |
| .github/workflows/*.lock.yml | Updated all workflow lock files to use v0.9.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Updated in 74c8e23 - added explicit "AWF-only feature" prefix to schema descriptions for |
DefaultFirewallVersionfromv0.8.2tov0.9.0inpkg/constants/constants.goSSLBumpboolean field toFirewallConfigstruct for HTTPS content inspectionAllowURLsstring slice field toFirewallConfigstruct for URL path filteringssl-bumpandallow-urlspropertiesgetSSLBumpArgshelper functiongetSSLBumpArgshelper functionSummary
This PR updates gh-aw-firewall from v0.8.2 to v0.9.0 and adds support for:
ssl-bump: true): Enables HTTPS content inspection for URL path filteringallow-urls): Restricts HTTPS access to specific URL patterns with wildcardsNote: These features are specific to AWF (Agent Workflow Firewall) and do not apply to Sandbox Runtime (SRT).
Usage Example
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.