[security-fix] Fix unhandled error in mcp_inspect.go waitForServerReady function

[github-actions]

Security Fix: Unhandled Error in Response Body Close

Alert Number: #409
Severity: LOW
Rule: G104 - Errors unhandled
File: pkg/cli/mcp_inspect.go:462

Vulnerability Description

The security scanner detected an unhandled error when calling resp.Body.Close() in the waitForServerReady function at line 462. According to Go best practices and security guidelines, errors from Close() operations should always be checked, as they can indicate resource leaks or I/O failures.

Fix Applied

Added proper error handling for resp.Body.Close():

• Changed from: resp.Body.Close()
• Changed to: Checking the error return value and logging a warning if closing the response body fails

This ensures that any failures in closing the response body are properly logged for debugging purposes, while not affecting the main logic flow since this is a non-critical cleanup operation during server readiness polling.

Security Best Practices

• Always check errors: Even for cleanup operations like Close(), error checking prevents silent failures and potential resource leaks
• Logging non-critical errors: Since this is a polling loop checking server readiness, logging the close error as a warning is appropriate without disrupting the main flow
• Resource cleanup: Properly handling close errors ensures better resource management

Testing Considerations

• The fix maintains the existing behavior: the function still returns true when the server responds successfully
• If closing the response body fails, a warning is logged but the function continues normally
• The polling loop continues to work as expected with improved error visibility

AI generated by Security Fix PR