-
Notifications
You must be signed in to change notification settings - Fork 32
Refactor safe outputs MCP server into modular utilities to avoid step length limits #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Created safe_outputs_config.cjs for config loading and processing - Created safe_outputs_append.cjs for output file appending logic - Created safe_outputs_handlers.cjs for all handler functions - Created safe_outputs_tools_loader.cjs for tools loading and registration - Updated safe_outputs_mcp_server.cjs to use modular files (481 -> 46 lines) - Updated compiler to write each utility file separately (avoiding max length limits) - Added comprehensive tests for each utility file (51 tests total) - All existing tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
The safe_outputs_type_validation.test.cjs was checking for type normalization in the main MCP server file, but after refactoring that logic moved to safe_outputs_append.cjs. Updated the test to check the correct location. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🤖 SYSTEM_INIT: Smoke Copilot No Firewall ACTIVATED. PROCESSING pull request. ALL SUBSYSTEMS ONLINE. |
|
📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
@copilot do not apply the bundler on the inserted code, and check the generated diff of the .lock.yml file again |
Smoke Test - Claude EngineLast 2 merged PRs:
Test Results:
Status: PASS
|
|
PRs reviewed:
|
Smoke Test Results (Run 19915300783)Last 2 merged PRs:
Test Results:
Overall Status: PASS
|
Smoke Test Results✅ Playwright Navigation: Successfully navigated to https://github.com Overall Status: ✅ PASS
|
Smoke Test ResultsLast 2 merged PRs:
Test Results:
Overall Status: PASS ✅
|
…ck files The safe_outputs_handlers.cjs file had prettier formatting that split long debug statements across multiple lines. When these were written to lock files, they appeared as multi-line statements instead of single lines. Fixed by reformatting the two debug statements to be on single lines. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in commit 57e5135. The issue was that the source .cjs file had prettier formatting that split long debug statements across multiple lines. The "bundler" (FormatJavaScriptForYAML) was correctly preserving the source formatting, but the source had unwanted line breaks. I reformatted the two debug statements to be on single lines, which now appear correctly in the lock files. |
|
@copilot format, lint, run tests |
Added prettier-ignore comments to the two debug statements that log patch generation success. This prevents prettier from splitting these lines across multiple lines in the source, which would then be reflected in the lock files. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Completed in commit 9331067:
Added prettier-ignore comments to prevent the debug lines from being auto-formatted across multiple lines. |
Refactor Safe Outputs MCP Server to Modular Files ✅
Results:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
Smoke Test Summary
Timestamp: 2025-12-04T02:12:10.612Z
Status: PASS
All tests passed: GitHub MCP, file operations, bash tools, and Playwright browser automation verified.