Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 24, 2025

JavaScript test was checking for "safe-outputs-mcp-server" in server startup output, but the actual server uses "safeoutputs" as its name.

Changes

  • Updated safe_outputs_mcp_sdk.test.cjs line 164 to expect [safeoutputs] prefix instead of "safe-outputs-mcp-server"

Context

The server name is defined in safe_outputs_mcp_server.cjs:

const SERVER_INFO = { name: "safeoutputs", version: "1.0.0" };

All debug output uses this name as a prefix: [safeoutputs] v1.0.0 ready on stdio

Original prompt

The CI is broken on main tree, please fix: https://github.com/githubnext/gh-aw/actions/runs/18792018478/job/53624349505


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix continuous integration issues on main tree Fix test expectation for safe outputs MCP server name Oct 24, 2025
Copilot AI requested a review from Mossaka October 24, 2025 21:20
@pelikhan pelikhan marked this pull request as ready for review October 24, 2025 21:21
Copilot AI review requested due to automatic review settings October 24, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing test expectation in the safe outputs MCP server test suite by correcting the expected server name in the startup output validation.

Key Changes:

  • Updated test assertion to match the actual server name format used in the codebase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Agentic Changeset Generator triggered by this pull request.

@pelikhan pelikhan merged commit cbd6c04 into main Oct 24, 2025
3 checks passed
@pelikhan pelikhan deleted the copilot/fix-ci-broken-main-tree branch October 24, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants