Remove .serena files and refactor isValidReaction to reactions.go #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove .serena files as per review feedback
Remove .serena files and refactor isValidReaction to reactions.go
Oct 23, 2025
pelikhan
merged commit a28f376
into
q/reaction-schema-default-validation-ab90b2019d4d10df
6 checks passed
pelikhan
added a commit
that referenced
this pull request
Oct 23, 2025
…on in parser (#2241) * Add default 'eyes' reaction in schema and reaction value validation in parser - Added 'default: eyes' to reaction field in main_workflow_schema.json - Added isValidReaction() helper function to validate reaction values - Added validation when parsing reaction field to reject invalid values - Added TestInvalidReactionValue test to verify validation works correctly This ensures that invalid reaction values are caught early with helpful error messages, and documents the default behavior in the schema. * Remove .serena files and refactor isValidReaction to reactions.go (#2242) * Initial plan * Remove .serena directory and move isValidReaction to reactions.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add getValidReactions function to compute valid reaction list dynamically (#2244) * Initial plan * Add getValidReactions function to compute valid reaction list from validReactions map Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: Q <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback from #2241 by making two organizational improvements:
Changes
1. Removed .serena directory
The
.serena/directory and its contents have been removed from the repository as they are no longer needed.2. Refactored reaction validation logic
Moved the
isValidReactionfunction fromcompiler.go(line 1509) to a new dedicated filepkg/workflow/reactions.go. This improves code organization by:reaction_outputs_test.go,reaction_discussion_test.go)3. Updated test validation
Modified
TestInvalidReactionValueincompiler_test.goto handle error messages from both schema validation and custom validation, as the JSON schema validation now occurs before the customisValidReactioncheck.Verification
Addresses review comments from @pelikhan in #2241.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.