Add directory creation for copilot engine --add-dir paths #2099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The copilot engine now automatically creates all directories specified in
--add-dirarguments before executing the copilot CLI. This prevents potential errors when the copilot CLI attempts to access directories that don't exist yet.Problem
The copilot engine builds a list of
--add-dirarguments that point to various directories:/tmp/,/tmp/gh-aw/,/tmp/gh-aw/agent//tmp/gh-aw/.copilot/logs//tmp/gh-aw/cache-memory/,/tmp/gh-aw/cache-memory-{id}/However, these directories were not being created before invoking the copilot CLI, which could cause failures if the directories don't exist.
Solution
Added a helper function
extractAddDirPathsthat:--add-dirflags--log-dir) in the listmkdir -pcommands for all directoriesExample Generated Output
Testing
Added comprehensive unit tests covering:
--add-dirpaths from engine configurationAll existing tests continue to pass, confirming backward compatibility.
Fixes
Resolves the issue where copilot CLI could fail if directories specified in
--add-dirarguments don't exist at runtime.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.