[WIP] Fix the failing GitHub Actions workflow Integration: Misc Part 2 #12784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Added extractAndReplacePlaceholders() and generatePlaceholderName() to runtime_import.cjs to convert template conditionals with GitHub expressions to placeholders - Updated integration tests to reflect that main workflow markdown uses runtime-import, so placeholders are generated at runtime, not during compilation - Tests now check for placeholders in the GitHub context section (which is in compiled YAML) and verify runtime-import macro is present for user content Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Updated TestGetActionPinsSorting to expect 43 pins instead of 42 - Updated TestGetMainWorkflowDeprecatedFields to expect timeout_minutes in deprecated list - This allows strict mode to properly detect and reject deprecated timeout_minutes field Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
merged commit f1350d1
into
copilot/add-support-import-github-actions
1 check passed
Copilot stopped work on behalf of
pelikhan due to an error
January 30, 2026 16:33
pelikhan
added a commit
that referenced
this pull request
Jan 30, 2026
…2775) * Initial plan * Add YAML workflow import support - parser and validation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add jobs merging from YAML workflow imports Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add example workflow demonstrating YAML import and fix lint issues Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add documentation for YAML workflow import feature Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Delete YAML_IMPORT_FEATURE.md documentation file Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Update action pins after recompile Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Use license-check.yml as example for YAML import instead of custom example Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Fix the failing GitHub Actions workflow Integration: Misc Part 2 (#12784) * Initial plan * Initial analysis of failing Integration: Workflow Misc Part 2 tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix deprecated fields validation by adding timeout_minutes to schema Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix template expression wrapping and update integration tests - Added extractAndReplacePlaceholders() and generatePlaceholderName() to runtime_import.cjs to convert template conditionals with GitHub expressions to placeholders - Updated integration tests to reflect that main workflow markdown uses runtime-import, so placeholders are generated at runtime, not during compilation - Tests now check for placeholders in the GitHub context section (which is in compiled YAML) and verify runtime-import macro is present for user content Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Fix action pins count and update parser test for timeout_minutes - Updated TestGetActionPinsSorting to expect 43 pins instead of 42 - Updated TestGetMainWorkflowDeprecatedFields to expect timeout_minutes in deprecated list - This allows strict mode to properly detect and reject deprecated timeout_minutes field Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing GitHub Actions workflow Integration: Workflow Misc Part 2 ✅ COMPLETE
All issues identified and fixed successfully!
Issue 1: Deprecated fields validation (TestStrictModeDeprecatedFields) ✅ FIXED
timeout_minutesnot in schema causes "Unknown property" error before deprecated field checktimeout_minutesto schema as deprecated field with replacement suggestionIssue 2: Template expression placeholders (TestTemplateExpressionWrappingIntegration, TestTemplateWithMixedExpressionsAndLiterals) ✅ FIXED
Additional fixes:
Final validation ✅ COMPLETE
make fmt- ✅ PASSmake lint- ✅ PASSmake test-unit- ✅ PASSOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.