Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

JavaScript tests were referencing create-agentic-workflow and debug-agentic-workflow as custom agent names. These are prompt file names in .github/aw/, not agents. The actual custom agent is agentic-workflows (dispatcher in .github/agents/).

Changes

  • actions/setup/js/log_parser_shared.test.cjs
    • Replace create-agentic-workflowagentic-workflows
    • Replace debug-agentic-workflowagentic-campaign-designer
    • Update test expectations to match actual custom agent structure

Context

Custom agents are .agent.md files in .github/agents/:

  • agentic-workflows.agent.md - dispatcher that routes to specialized prompts
  • agentic-campaign-designer.agent.md - campaign design agent

Prompt files are .md files in .github/aw/:

  • create-agentic-workflow.md - creation prompt (not an agent)
  • debug-agentic-workflow.md - debug prompt (not an agent)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build git conf�� user.email test@example.com /usr/bin/git --write scripts/**/*.js 64/bin/go git init�� 64/bin/go go /usr/bin/git -json GO111MODULE layTitle git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Find instances of create-agentic-workflow agent and rename to agentic-workflows agent.

Custom agent used: technical-doc-writer
AI technical documentation writer for GitHub Actions library using GitHub Docs voice


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 30, 2026 00:34
…tic-workflows

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…tic-workflows

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename create-agentic-workflow agent to agentic-workflows agent Fix custom agent name references in log parser tests Jan 30, 2026
Copilot AI requested a review from pelikhan January 30, 2026 00:48
@pelikhan pelikhan marked this pull request as ready for review January 30, 2026 04:13
@github-actions
Copy link
Contributor

🛡️ Security Posture Analysis

This PR contains changes that affect the security posture. Please review the following concern:

🟠 Network Boundary Expansion: JSR (JavaScript Registry) Domain Added

Location: Multiple workflow files (22 .lock.yml files)

Change Detected:

- --allow-domains api.business.githubcopilot.com,...,npmjs.com,npmjs.org,...
+ --allow-domains '*.jsr.io,api.business.githubcopilot.com,...,jsr.io,...,npmjs.com,npmjs.org,...'

Security Impact: This change expands the network boundary by adding:

  • *.jsr.io (wildcard pattern allowing all JSR subdomains)
  • jsr.io (main JSR domain)

The JSR (JavaScript Registry) domains are being added to the firewall allowlists across all sandboxed workflows. While JSR is a legitimate JavaScript package registry, this represents a network boundary expansion that:

  1. Uses a wildcard pattern (*.jsr.io) which allows access to any subdomain
  2. Is not mentioned in the PR description (which only discusses test file changes)
  3. Applies to 22 different workflow files

Affected Workflows:

  • firewall.lock.yml
  • jsweep.lock.yml
  • mcp-inspector.lock.yml
  • release.lock.yml
  • And 18+ other workflow files

Recommendation:

  1. Verify this change is intentional - The PR description mentions only test file changes related to custom agent name references, but this network change is unrelated
  2. Document the justification - If JSR access is needed for Deno package management or similar functionality, please add this to the PR description
  3. Consider specificity - If only specific JSR subdomains are needed, replace the wildcard *.jsr.io with explicit subdomain(s)

Summary

Category Severity Count
Network Boundary Expansion 🟠 High 1

Note: This is an automated security analysis. The JSR domains may be a legitimate addition for Deno/modern JavaScript tooling support. However, since this change is not mentioned in the PR description and uses a wildcard pattern, it warrants explicit review and justification from the PR author or maintainers.

AI generated by Security Guard Agent 🛡️

@pelikhan pelikhan merged commit fedba94 into main Jan 30, 2026
158 checks passed
@pelikhan pelikhan deleted the copilot/rename-create-agentic-workflow branch January 30, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants