Remove top-level safe-jobs support, enforce safe-outputs.jobs #12439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…e-jobs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
@copilot remove all support for top level safe-jobs and backward compatibility. |
Copilot
AI
changed the title
[WIP] Remove support for top-level "safe-jobs" in front matter
Remove top-level safe-jobs support, enforce safe-outputs.jobs
Jan 29, 2026
Contributor
Author
Done in commit 985ff29. Changes made:
Top-level |
pelikhan
reviewed
Jan 29, 2026
| detectionLog.Printf("No 'on' field detected - treating as shared agentic workflow") | ||
|
|
||
| // Reject top-level "safe-jobs" field (only safe-outputs.jobs is supported) | ||
| if err := c.validateNoTopLevelSafeJobs(frontmatterForValidation, cleanPath); err != nil { |
| } | ||
|
|
||
| // Reject top-level "safe-jobs" field before schema validation (provides better error message) | ||
| if err := c.validateNoTopLevelSafeJobs(frontmatterForValidation, cleanPath); err != nil { |
|
|
||
| // validateNoTopLevelSafeJobs validates that the frontmatter does not contain a top-level "safe-jobs" field. | ||
| // Only safe-outputs.jobs is supported. | ||
| func (c *Compiler) validateNoTopLevelSafeJobs(frontmatter map[string]any, filePath string) error { |
…ches it Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level
safe-jobsis no longer supported. Onlysafe-outputs.jobsis valid.Changes
parseSafeJobsConfig()to operate directly on jobs map, removing internal wrapper patternsafe-jobsis rejected by JSON schema as an unknown propertyExample
Previously tolerated (now rejected):
Required syntax:
Error when using deprecated syntax:
The JSON schema validation is sufficient to catch and reject the unsupported top-level
safe-jobsfield.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.