[dev] fix: Add build tag to TestMain and include poem #12393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added close_expired_pull_requests.cjs script following same pattern as issues/discussions - Updated maintenance_workflow.go to include pull requests in expires checking - Added pull-requests: write permission to maintenance job - Added step to close expired pull requests in maintenance workflow - Updated documentation in maintenance workflow comments Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Created comprehensive test suite for close_expired_pull_requests.cjs - Tests cover: no PRs found, expired PRs, not expired PRs, error handling, pagination - All 5 tests passing - Follows same testing pattern as close_expired_discussions Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Updated generatePullRequestConfig to include expires parameter - Updated function call to pass CreatePullRequests.Expires - Config now properly includes expires field in generated workflows - Verified with test workflow compilation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
All requirements implemented and tested: - Expires field on create-pull-request configuration ✓ - XML comment marker for PR expiration ✓ - AI footer with expiration date ✓ - Maintenance job step to close expired PRs ✓ - Full test coverage ✓ - All workflows recompiled successfully ✓ Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Changed "Pull Request" to "pull-request" in XML comment for searchability as requested by @pelikhan Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Added expires: 7d to create-pull-request configurations in: - daily-doc-updater.md - daily-workflow-updater.md This ensures PRs from daily automation workflows are automatically closed after 7 days if not merged. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Modified dev.md workflow to: - Add single line poem to poems.txt - Create pull request with expires: 2h - Set as draft PR with [dev] prefix - Updated description and requirements Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Merged main branch into feature branch - Resolved merge conflict in dev.lock.yml by keeping dev version - Ran make fmt - all files formatted successfully - Ran make lint - all validations passed - All 141 workflows recompiled successfully Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
duplicate TestMain definitions when running with integration tests. Also added poems.txt with a single line poem as requested.
Base automatically changed from
copilot/add-expires-field-to-pull-request
to
main
January 29, 2026 00:18
This was referenced Jan 29, 2026
Contributor
Author
|
This pull request was automatically closed because it expired on 2026-01-29T02:10:54.753Z. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two items:
//go:build !integrationtag topkg/cli/test_main_test.goto prevent duplicate TestMain definitions when running tests with integration tagpoems.txtwith a single line poem as requestedChanges
pkg/cli/test_main_test.go: Added build tag to exclude unit test TestMain when integration tests runpoems.txt: New file with a single line poemTesting
✅ Build succeeded with
⚠️ Tests run with
make buildmake test- 5 pre-existing test failures detected (unrelated to this change)Test Failures (Pre-existing)
The following test failures were present before this PR:
TestGenerateAndCompileCampaignOrchestrator- Campaign orchestrator purge issueTestCompileWorkflows_PurgeCampaignOrchestrators- Campaign purge logicTestMCPServer_StatusToolWithJq- MCP server status with jqTestExtractLogMetricsWithAwOutputFile- Metrics extraction issueTestAddMCPTool_BasicFunctionality- MCP tool additionThe TestMain build tag fix resolves the immediate build error that prevented any tests from running.