Skip to content

Remove redundant manual discussion closure from daily-observability-report #11799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Jan 25, 2026
Merged

Remove redundant manual discussion closure from daily-observability-report #11799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d472f54
Initial plan
Copilot Jan 25, 2026
96dfc47
Fix: Remove redundant Phase 6 manual discussion closure in daily-obse…
Copilot Jan 25, 2026
aed374c
Debug complete: Fixed redundant discussion closure in daily-observabi…
Copilot Jan 25, 2026
023770b
Update success criteria to reflect automatic discussion closure
Copilot Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions .github/workflows/daily-observability-report.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 4 additions & 11 deletions .github/workflows/daily-observability-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,18 +273,12 @@ runs_with_missing_logs = (firewall_enabled_workflows - firewall_logs_present) +

Create a summary table of all runs analyzed with their observability status.

## Phase 6: Close Previous Reports

Before creating the new discussion, find and close previous observability reports:

1. Search for discussions with title prefix "[observability]"
2. Close each found discussion with reason "OUTDATED"
3. Add a closing comment: "This report has been superseded by a newer observability report."

## Phase 7: Create Discussion Report
## Phase 6: Create Discussion Report

Create a new discussion with the comprehensive observability report.

**Note**: Previous observability reports with the same `[observability]` prefix will be automatically closed when the new discussion is created. This is handled by the `close-older-discussions: true` setting in the safe-outputs configuration - you don't need to manually close them.

### Discussion Format

**Title**: `[observability] Observability Coverage Report - YYYY-MM-DD`
Expand Down Expand Up @@ -421,8 +415,7 @@ A successful run will:
- ✅ Check all MCP-enabled runs for gateway.jsonl presence
- ✅ Calculate coverage percentages and identify gaps
- ✅ Flag any runs missing critical logs as CRITICAL
- ✅ Close previous observability discussions
- ✅ Create a new discussion with comprehensive report
- ✅ Create a new discussion with comprehensive report (previous discussions automatically closed)
- ✅ Include actionable recommendations

Begin your analysis now. Download the logs, analyze observability coverage, and create the discussion report.