[jsweep] Clean check_permissions.cjs #11775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned
check_permissions.cjsby applying modern JavaScript patterns and improving code clarity.Changes Made
Code Improvements
eventName,actor, andrepofromcontextin a single destructuring operationrepoproperty torepoNamewhen further destructuringownerandrepofromcontext.repoownerandrepofromcontext.repointo the function's destructuring patternExecution Context
core,github, andcontextglobals)@ts-checkdirectiveTesting
Validation Results
All validation checks passed successfully:
✅ Formatting:
npm run format:cjs- All files formatted correctly✅ Linting:
npm run lint:cjs- No linting errors✅ Type checking:
npm run typecheck- No type errors✅ Tests:
npm run test:js -- check_permissions.test.cjs- All 14 tests passedCode Comparison
Before:
After:
Impact
Part of the ongoing effort to modernize and clean JavaScript files in the
actions/setup/js/directory.