-
Notifications
You must be signed in to change notification settings - Fork 43
Update smoke-Claude to import go-make shared workflow #11513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot Continue work |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
Set working directory to GITHUB_WORKSPACE for safe-inputs MCP handlers | [WIP] Normalize header levels in static analysis report | [jsweep] Clean campaign_discovery.cjs | [docs] Unbloat Security Architecture documentation
|
Smoke Test ResultsOverall Status: ✅ PASS Last 2 Merged PRs:
Test Results:
|
.github/workflows/smoke-claude.md
Outdated
| 2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from ${{ github.repository }} (use args: "pr list --repo ${{ github.repository }} --limit 2 --json number,title,author") | ||
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools or the safeinputs-go/safeinputs-make tools from the go-make shared workflow) | ||
| 4. **Playwright Testing**: Use playwright to navigate to https://github.com and verify the page title contains "GitHub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot add test to call the safeinputs make build tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
PRs: Set working directory to GITHUB_WORKSPACE for safe-inputs MCP handlers | [WIP] Normalize header levels in static analysis report
|
Smoke Test Results - ✅ PASSPRs reviewed:
Overall: ✅ PASS Run: https://github.com/githubnext/gh-aw/actions/runs/21293345340
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test ResultsLast 2 merged PRs:
Test Results:
Overall Status: PASS
|
Updates the
smoke-claudeworkflow to import theshared/go-make.mdshared workflow, which providessafeinputs-goandsafeinputs-maketools for executing Go and Make commands.Changes Made
shared/go-make.mdto theimportssection in.github/workflows/smoke-claude.mdsafeinputs-goandsafeinputs-maketools are available alongside Serena's MCP toolssafeinputs-maketool with args "build" to verify the build succeeds.github/workflows/smoke-claude.lock.ymlfile with the new safe-input tools properly integratedNew Tools Available
The workflow now includes two additional safe-input tools:
safeinputs-go: Execute any Go command (e.g.,go test ./...,go build ./cmd/gh-aw,go mod tidy)safeinputs-make: Execute any Make target (e.g.,make build,make test-unit,make lint,make agent-finish)These tools provide an alternative to Serena MCP for Go/Make command execution with consistent logging and proper shell script handling, while maintaining backward compatibility with existing Serena MCP functionality.
Testing
The smoke test workflow now includes 9 tests (up from 8), with the new Make Build Testing positioned after Serena MCP testing to validate that the
safeinputs-maketool works correctly by building the project.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
smoke-claudeworkflow to import the sharedgo-makeworkflow and exposesafeinputs-goandsafeinputs-maketools for running Go and Make commands used by CI and local testing. This is an internal tooling update and does not change public APIs.Changeset
smoke-claudeworkflow to import the sharedgo-makeworkflow and exposesafeinputs-goandsafeinputs-maketools for running Go and Make commands used by CI and local testing. Internal tooling update; no public API changes.