-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Labels
automationcode-qualitycookieIssue Monster Loves Cookies!Issue Monster Loves Cookies!securitytask-mining
Description
Description
14 workflows are triggered by risky events (issue_comment, pull_request_target) but use default permissions (read-write access to most resources). This violates the principle of least privilege and creates a supply chain security vulnerability identified by the poutine scanner.
This issue was discovered in the Static Analysis Report #12756.
Security Impact
Severity: High
Risk: Workflows triggered by untrusted events (comments, external PRs) have excessive permissions, enabling potential privilege escalation attacks.
Files Affected (Edit .md files, NOT .lock.yml)
.github/workflows/ai-moderator.md.github/workflows/archie.md.github/workflows/brave.md.github/workflows/cloclo.md.github/workflows/grumpy-reviewer.md.github/workflows/mergefest.md.github/workflows/pdf-summary.md.github/workflows/plan.md.github/workflows/pr-nitpick-reviewer.md.github/workflows/q.md.github/workflows/scout.md.github/workflows/security-review.md.github/workflows/tidy.md.github/workflows/unbloat-docs.md
Fix Pattern
Before:
---
name: Example Workflow
on:
issue_comment:
types: [created]
---After:
---
name: Example Workflow
on:
issue_comment:
types: [created]
permissions:
contents: read
issues: write
pull-requests: write
---Common Permission Patterns
Choose the minimal permissions needed:
- Read data and create reports:
contents: read, issues: write, pull-requests: read - Respond to comments:
contents: read, issues: write, pull-requests: write - Modify code:
contents: write, issues: write, pull-requests: write
Success Criteria
- All 14 workflows have explicit
permissions:section in frontmatter - Each workflow uses minimal required permissions
- Workflows recompiled with
make recompile - Poutine scanner no longer reports
default_permissions_on_risky_eventswarning - All workflows continue to function correctly
Priority
High - Security vulnerability affecting multiple workflows.
References
Source
Extracted from Static Analysis Report #12756
AI generated by Discussion Task Miner - Code Quality Improvement Agent
- expires on Feb 14, 2026, 5:19 AM UTC
Metadata
Metadata
Assignees
Labels
automationcode-qualitycookieIssue Monster Loves Cookies!Issue Monster Loves Cookies!securitytask-mining