-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Labels
automationcode-qualitycookieIssue Monster Loves Cookies!Issue Monster Loves Cookies!refactoringtask-mining
Description
Description
A hardcoded ANSI escape sequence in add_interactive_orchestrator.go bypasses the console package's TTY detection and adaptive styling system. This is an anti-pattern identified in the Terminal Stylist analysis.
Current State
- File:
pkg/cli/add_interactive_orchestrator.go - Line: 65
- Code:
fmt.Fprint(os.Stderr, "\033[H\033[2J") // Clear screen - Issue: No TTY detection, hardcoded ANSI codes
Suggested Changes
Replace the hardcoded ANSI sequence with a console package function that includes TTY detection:
Option 1: Add new console package function
// pkg/console/console.go
func ClearScreen() {
if !isTTY() {
return
}
fmt.Fprint(os.Stderr, "\033[2J\033[H")
}Option 2: Use existing Lipgloss functionality
// If Lipgloss provides a clear screen helper
console.ClearScreen()Then update the call site:
// pkg/cli/add_interactive_orchestrator.go:65
console.ClearScreen() // TTY-aware, consistent with console packageFiles Affected
pkg/cli/add_interactive_orchestrator.go(line 65)pkg/console/console.go(add newClearScreen()function if needed)
Success Criteria
- Hardcoded ANSI sequence removed
- TTY detection implemented (no clearing on pipes/redirects)
- Consistent with console package patterns
- All existing tests pass
- Clear screen functionality works in interactive mode
Benefits
- Consistency: Aligns with console package architecture
- TTY-aware: Doesn't send ANSI codes to pipes/redirects
- Maintainability: Centralized control of terminal operations
- Accessibility: Respects
ACCESSIBLEenvironment variable
Source
Extracted from Terminal Stylist Report discussion #12701
Priority
Medium - Improves code consistency and terminal compatibility
Estimated Effort
30 minutes - 1 hour
AI generated by Discussion Task Miner - Code Quality Improvement Agent
- expires on Feb 13, 2026, 9:14 AM UTC
Metadata
Metadata
Assignees
Labels
automationcode-qualitycookieIssue Monster Loves Cookies!Issue Monster Loves Cookies!refactoringtask-mining