fix: MCP session management in gateway tests #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Docker API version detection in run_containerized.sh to dynamically query Docker daemon's minimum API version instead of hardcoding 1.43 - Fix session ID persistence in test_serena_via_gateway.sh by storing session ID in a file instead of shell variable to survive subshell boundaries created by $() command substitution - Add local image check to skip pulling when gateway image exists locally - Session ID is now properly captured from Mcp-Session-Id response header and included in all subsequent MCP requests This fixes 'method is invalid during session initialization' errors that occurred because subsequent requests weren't including the session ID.
This was referenced Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 'method is invalid during session initialization' errors that occurred because subsequent requests weren't including the session ID.