Repository navigation
Badge Chat and Document activity with one still petrol dot, and even out the title bar - #518
Merged
Merged
Conversation
Collaborator
Author
|
Review: Changes needed (one small fix) I checked this in a headless browser on a fake-GitHub server, at 1440×900 (1x and 2x), 1024 and 820 wide, and on a 390×844 phone (3x). I looked at the unread Chat badge at rest, on hover, while pressed and with keyboard focus, at the Document dot and its hover state, and at the phone tab bar. What works
Findings
I didn't test a long title truncating next to the icon or a Zoom child crumb locally (the fake server has no child documents). The PR's 1440 and 820 before/after shots cover the Zoom crumb. CI: container, e2e, and format/lint/types/tests all pass. |
Collaborator
Author
|
Addressed the review in commit 448f346:
No change to |
MaggieAppleton
force-pushed
the
design-chat-toggle-badge
branch
from
October 12, 2026 16:39
448f346 to
2202e3d
Compare
…out the title bar With the document expanded, the title bar's toggle shows the Chat glyph instead of inward arrows, and unread activity is a badge on that glyph's corner, knocked out of the bar with a ring that follows the ghost fill. The Document view's new-changes mark is the same solid dot, inline after the label and no longer pulsing. The phone's tab marks share the treatment. The title bar's project, title and Zoom crumb now read at the views' text size, the repository icon returns before the project, and the project sits as far from the toggle's rule as the toggle's glyph sits from the edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reviewed dynamic owners in workspace.tsx keep the same data flow:
SurfaceToggle still composes motionContract("feedback") into its icon
span and, while unread, into the badge span (now nested in the icon);
the Chat pane presence class is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dot class The knockout ring used the edge width, which is a hairline on Retina, so it now uses half a spacing step. The document mark's test checks for animation on its data attribute and the shared dot class instead of a class nothing styled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
design-chat-toggle-badge
branch
from
October 12, 2026 19:21
2202e3d to
f24e233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Three fixes to the document sheet's two header bars, all from Maggie's screenshots.
1. Chat toggle badge. With the document expanded, the toggle shows the Chat speech-bubble glyph (
MessageIcon, the composer's Chat icon) in place of the inward arrows. The unread mark moves onto the glyph's top-right corner: an 8px petrol dot (was 6px) with a 2px ring in the surface colour, so it cuts cleanly out of the glyph and never touches the label. The ring follows the ghost button's hover and pressed fills, so no halo shows. Its accessible name still announces state (Show chat, 1 unread,Show chat, Planner working). The appear motion reuses the existingcountfeedback (opacity and scale, pointer input only, off under reduced motion). The chat-open state keeps itsExpandIcon.2. Document "new changes" mark. The mark was a hollow, pulsing ring for "writing" and a 6px dot overlapping the end of "Document". It's now the same solid 8px petrol dot as the Chat badge, inline after the label and vertically centred. The tab grows to fit it (
gap-1.5). The pulse is gone. Accessible names are unchanged (Document, new changes,Document, Planner writing). On the phone tab bar, the Chat and Document marks use the same treatment: an 8px fill with a 2px page ring. Before, the 2px border left only a 4px fill.3. Title bar evenness
--text-xs(12.3px) to--text-sm(14px), the size the views bar, the Chat label and the counts already use. Both bars now read at one size.DocumentIcon, the one in the header before Put the document's title and views on its sheet, and zoom children by default #507) returns before the project name. It is 14px like the toggle glyphs, centred on the text, tertiary colour, and sits 6px from the project, the same as glyph to label in the toggle.--control-padding-inline. The icon now sits 16px after the divider, matching the 16px from the bar edge to the toggle glyph and from the "Chat" label to the divider.Chat open
Expanded, unread chat
After, hover / keyboard focus / pressed:

Document "new changes"
Zoom child crumb (1440 and 820 wide; the title still truncates first)
Phone tab bar (Chat unread, Document new changes)
Checked in the browser (headless, 2x)
Tests
e2e/responsive-activity.e2e.ts: the badge sits left of the "Chat" label.e2e/document-activity.e2e.ts: on desktop the dot has no animation, stays inside the tab and is centred on it.document-activity.test.ts: the pulse test is replaced by "the document mark stays still".icon-assets.test.ts: the workspace now usesMessageIcon, notCollapseIcon.Needs a look
--text-sm, which the views already use. If the bars should come down to 12.3px instead, it's a one-line token swap.Renew design-contract review for the Chat toggle badgecommit. The data flow is unchanged:feedbackstill reaches two spans inSurfaceToggle.🤖 Generated with Claude Code